Thread: Simple printf and for loop help

A while back I wrote a program to annoy my programming teacher that would open a terminal window and sing the "99 bottles of 'coke' on the wall" song. I wrote that in C++, which was a simple enough process, but now that I'm writing it in C, I get a few errors. I'm really new to C and I promise not to annoy anyone else after this without really trying to look around. This should be a very simple fix for anyone with experience, so I'll leave you guys to it.

Source of beer.c

Code:

#include<stdio.h>
int main() {
int i=0;
for (i=0;i!=100;i--) {
    int j = i-1;
    printf(i," bottles of beer on the wall, ",i,"bottles of beer take one down pass it around, ", j," bottles of beer on the wall!\n");
    }
return 0;
}

Compiler error output

Code:

beer.c: In function ‘main’:
beer.c:6: warning: passing argument 1 of ‘printf’ makes pointer from integer without a cast
/usr/include/stdio.h:339: note: expected ‘const char * __restrict__’ but argument is of type ‘int’

I would like to thank you guys ahead of time for helping me with this and I look forward to a long mutually beneficial relationship.

Edit: The printf() line is pretty long, in C++ I could just << and start on the next line, it would be helpful if there were a way to do that here as well, I think it's a '\' but I wasn't willing to chance it.

Also, I'm using nano/gedit running Ubuntu 10.04 if that matters at all.

Originally Posted by jimblumberg

Did you look up the documentation for printf()? What should the first argument be? What is your first argument?
Your printf should look something like:

Code:

int num = 10;
printf("%d %s\n", num, "Print this string");

Jim

Sorry Jim, that can't be right - everyone knows this is a song, and your call to printf() doesn't have a single musical note in it!



Merry Christmas!

Andrew:

Code:

for(bottleNum=99;bottleNum!=0;bottleNum--) {
    printf("%d bottles of beer on the wall,\n%d bottles of beer,\n",bottleNum,bottleNum);
    printf("You take one down, and pass it around, %d bottles of beer on the wall\n"bottleNum-1);
}

Here's the source:

Code:

#include<stdio.h>
int main() {
int i=99;
for (i;i!=2;i--) {
    printf("\n\n%d bottles of beer on the wall, %d bottles of beer.",i,i);
    printf("\nYou take one down, and pass it around, %d bottles of beer on the wall!",i-1);
}
//  Number of bottles of beer on the wall is too low to be grammatically
//  correct, last two lines (verses?) will be printed the lazy way.
printf("\n\n2 bottles of beer on the wall, 2 bottles of beer.");
printf("\nYou take one down, and pass it around, 1 bottle of beer on the wall!");

printf("\n\n1 bottle of beer on the wall, 1 bottle of beer.");
printf("\nYou take one down, and pass it around, no more bottles of beer on the wall!\n\n");

return 0;
}

Last 3 'lines' of output:

Code:

3 bottles of beer on the wall, 3 bottles of beer.
You take one down, and pass it around, 2 bottles of beer on the wall!

2 bottles of beer on the wall, 2 bottles of beer.
You take one down, and pass it around, 1 bottle of beer on the wall!

1 bottle of beer on the wall, 1 bottle of beer.
You take one down, and pass it around, no more bottles of beer on the wall!

?@?~/c/boredom$ _

Thank you all for your help, I hope this leaves you all feeling accomplished... or at least a little tipsy :P

I seriously just started messing around with C two days ago, last night being the first try at doing anything beyond printing strings. Now that I understand the variable printing system a little better after reading a OUCS (Oxford University Computer Services) 'primer' after a google search, C is a little easier for me

Just don't be expecting me to program an o/s anytime soon. Cheers all.

Edit: Next on the menu is file manipulation (input/output etc.). It's gonna be fun!!!