Segmentation Fault

Hello everyone,

I've been programming in Java for approx 1.5 years and am moving to C now for my CS degree. I have a book that I'm moving through pretty fast but am kind of stuck on a rand number problem which keeps giving me a segmentation fault error. Right now I'm stuck because this is an example in the book which is compiling and linking but not executing. I'm on Ubuntu 11.10 if it matters I think the book was designed for windows. Here is the block of code.

Code:

#include<stdio.h>

main(){
   int iRandNum = 0;
   srand(time());
   iRandNum = (rand() % 4) + 1;
   printf("%d", iRandNum);
}

I've been googling all day and the only thing I can come up with is that it's an OS specific problem because it has something to do with a hardware error. I don't think that's what it is but that's what I've been seeing. Thanks a lot guys

First,

Code:

#include <stdlib.h>  // for rand()
#include <time.h>   // for time()

Tho because they both return the default int, everything will work out anyway. Which BTW, main() should also return an int.

Next, that code should not even compile -- time() requires an argument. What compiler are you using?

Originally Posted by MK27

First,

Next, that code should not even compile -- time() requires an argument. What compiler are you using?

thats probably why it is crashing. time wants a pointer and it is getting garbage. it compiles because it doesn't have the prototypes for time and rand so it defaults.

I am using gcc.

I've changed my code to look like such

Code:

#include<stdio.h>
#include<time.h>    // added
#include<stdlib.h>   // added

main(){
   int one = 0;
   srand(time());
   one = (rand() % 4)+1;
   printf("%d", one);
   return 0;             // added
}

after such I'm now getting errors compiling.

error: too few arguments to function 'time'
/usr/include/time.h:186:15 note: declared here



Ok, I fixed/figured it out. Thank you dmh and mk27. I placed "NULL" into the time function and like magic it works thanks guys!!!!
Can I some how mark this as solved or close it?

Originally Posted by seanfmglobal

Can I some how mark this as solved or close it?

Nah, no need. Maybe someone will still add more ideas... but threads usually just stay open forever. Less work for the moderators that way.