can you spot the error in my code?

hi, i am trying to sort a file and i keep getting a run failed when i call the method sortList.I have gone through my code but i cant find any error

Code:

void sortList(FILE *p,int noofchil){
    struct child *temp3;
    struct child *temp1;
    struct child *temp2;;
    int in;
    int out;
    printf("dd");
    
           
    	 for(out=noofchil-1;out>1;out--)
         {
    		 for(in=0;in<out;in++)
                 {
                     fseek(p,sizeof(struct child)*in ,SEEK_SET);
                     fread(temp1,sizeof(struct child),1,p);
                     fseek(p,sizeof(struct child)* (in +1) ,SEEK_SET);
                     fread(temp2,sizeof(struct child),1,p);
    			 if(compareChilds(temp1,temp2)==1)
                         {
    				 temp3=temp2;
                                 temp2=temp1;
                                 temp1=temp3;
                                 fseek(p,sizeof(struct child)*in ,SEEK_SET);
                                 fwrite(temp1,sizeof(struct child),1,p);
                                 fseek(p,sizeof(struct child)*(in+1) ,SEEK_SET);
                                 fwrite(temp1,sizeof(struct child),1,p);
                                 
    			 }
                        
    				
    		 }
    	 }
    
}

Code:

    struct child *temp3;
    struct child *temp1;
    struct child *temp2;;

You NEVER allocated any space for the above pointers!
(Likely you should NOT be using pointers.)
You NEVER set them to a valid address; so, you are randomly over writing the memory space.

Tim S.

Originally Posted by stahta01

Code:

    struct child *temp3;
    struct child *temp1;
    struct child *temp2;;

You NEVER allocated any space for the above pointers!
(Likely you should NOT be using pointers.)
You NEVER set them to a valid address; so, you are randomly over writing the memory space.

Tim S.

i cant believe i made such a mistake

Originally Posted by stahta01

Code:

    struct child *temp3;
    struct child *temp1;
    struct child *temp2;;

You NEVER allocated any space for the above pointers!
(Likely you should NOT be using pointers.)
You NEVER set them to a valid address; so, you are randomly over writing the memory space.

Tim S.

Just observed an erro my sort algorithm is not working properly..certain values are being repeated

Originally Posted by sigur47

Just observed an erro my sort algorithm is not working properly..certain values are being repeated

How many different items do you write out?

Tim S.