Thread: Reading an input file into a struct.

Code:

#include <stdio.h>


typedef struct
{
	char name[20];
	short score;
}Student_Record;


int main()
{
	FILE * ptr;


	Student_Record test;
	int count, k;
	test.name;
	test.score;


	ptr = fopen("input.txt", "r");


	if(ptr == NULL)
	{
		printf("Open operation failed.\n\n\n");
		return 1;
	}


	fscanf(ptr, "%d", &count);


	for(k = 0; k < count; k++)
	{
		fscanf(ptr, "%s%d", &test.name, &test.score);
	}


	fclose(ptr);


	printf("|   Test Results   |\n");
	printf("|------------------|\n");
	
	for(k = 0; k < count; k++)
	{
		printf("|%s       |%d      |\n", test.name, test.score);
	}


	printf("|------------------|\n");


	getch();
	return 0;
}

I am pretty sure that I have my variables wrong, or something along those lines. I can compile+run without any errors, yet it evidently skips my for loop that is supposed to print the test.name's and test.score's.

Can somebody point me in the right direction without blatantly giving me the answer? (Since this is the basis on what object oriented programming is going to be about, I would like to at least have a detailed explanation of what needs done if you can't lead me in the right direction for solving it myself.)

Thanks in advance,
~Alan

Code:

$ gcc -Wall -g -std=c99  struct.c   -o struct
struct.c: In function ‘main’:
struct.c:18: warning: statement with no effect
struct.c:19: warning: statement with no effect
struct.c:37: warning: format ‘%s’ expects type ‘char *’, but argument 3 has type ‘char (*)[20]’
struct.c:37: warning: format ‘%d’ expects type ‘int *’, but argument 4 has type ‘short int *’

Lines 18 and 19 can be removed. They don't actually do anything.
Line 37: You don't need the & with strings (char arrays). The name of the array is already a pointer to the first element. Also, a short and an int are not the same to scanf. Read the scanf documentation to find out how to specify short.

Then, look at your definition of test. It's a single Student_Record. You can't store 5 test scores in a single record, so it only remembers the last one you read. If you want to read all count entries, then print them later, you need an array of at least count elements.

it helps if you post the contents of the input file and exactly what is printed for output.