Need help for my assignment .

[kaizan777]

// FOP assignment.
//


#include "stdafx.h"
#include <stdio.h>
#include <conio.h>


int main(void)
{
    int a,i,j;
    int choices;
    int num;
    int language;


    printf("For English press 1\n");
    printf("Untuk Bahasa Malaysia tekan 2\n");
    printf("Answer/Jawapan: ");
    scanf("%d", &language);


    //English
    if(language == 1)
    {
        printf("\nChoose the shape of your choice");
        printf("\n1.Triangle\n2.Rectangle\n3.Diamond\n");
        printf("\nAnswer: ");
        scanf("%d", &choices);
        printf("\nEnter the size of the shape you want\n");
        printf("\nAnswer: ");
        scanf("%d", &num);
    }


    //Malay
    if(language == 2)
    {
        printf("\nSila pilih bentuk pilihan anda");
        printf("\n1.Segi Tiga\n2.Segi Empat Tepat\n3.Berlian\n");
        printf("\nJawapan: ");
        scanf("%d", &choices);
        printf("\nSila masukkan saiz bentuk yang anda mahu\n");
        printf("\nJawapan: ");
        scanf("%d", &num);
    }


    // This is for Triangle
    if(choices == 1)
        for (i = 1; i <= num; i++)
    {
        for (j = 1; j <= i; j++)
        {
            printf("*");
            printf(" ");
        }
        printf("\n");
    }
    printf("\n");


    // This is for Rectangle
    if(choices == 2)
        for (i = 1; i <= num; i++)
    {
        for (j = 1; j <= num; j++)
        {
            printf("*");
            printf(" ");
        }
        printf("\n");
    }
    printf("\n");


    // This is for Diamond
    if (choices == 3)
     for (i = 1; i <= num; i++)
     {
 {
     for ( j = num; j >= i; j--)
     {
         printf(" ");
     }
     for ( j = 1; j <= i; j++)
     {
         printf(" *");
     }
     {
         printf("\n");
     }
 }
     for ( i = num; i >= 1; i--)
 {
     for ( j = num; j >= i; j--)
     {
         printf(" ");
     }
     for ( j = 1; j <= i; j++)
     {
         printf(" *");
     }
     {
         printf("\n");
     }
         
 }
     getch();
     }
     getch();
}

Is there something wrong ? I couldn't get my diamond shape right..

[MK27]

It looks very much to me like you have inserted closing braces willy-nilly in order to balance out an inappropriate use of opening braces, and so your "flow control" is all flow, no control. Eg, not only is your diamond shape wrong, but this program will never end unless you kill it:

     for ( i = num; i >= 1; i--)

Is inside this block:

     for (i = 1; i <= num; i++)

So first iteration of the outside loop, i == 1. For infinite subsequent iterations, i == 2.

[KenJackson]

I didn't try to compile it, but it just looks like there's a misplaced set of curly braces. If you move them them, indent, and delete other superfluous braces, you get something like this:

    // This is for Diamond
    if (choices == 3)
    {
       for (i = 1; i <= num; i++)
       {
           for ( j = num; j >= i; j--)
               printf(" ");
           for ( j = 1; j <= i; j++)
               printf(" *");
           printf("\n");
       }
       for ( i = num; i >= 1; i--)
       {
           for ( j = num; j >= i; j--)
               printf(" ");
           for ( j = 1; j <= i; j++)
               printf(" *");
           printf("\n");
       }
   }

What's it look like?

BTW, it would be helpful to use variables like row instead of i and column instead of j to make it more understandable.