Thread: C file creation and strings

I need to create a function that prompts the user to enter a string and use that string to create a file to which I will store data

this runs, but does not create the file as I wish:

Code:

void saveFile (char** list, int size, char* filename)
{
     int i, length;

     printf("\nPlease enter the name of the file to which you would like to save your output:\n"); 
     printf("\tOnly use alphabetical characters, numbers, or '_'\n");
     printf("\t\tMax of 15 characters per name\n");
     scanf("%15s", filename);
     FLUSH;

    strcat(filename, ".txt");
    fp2 = fopen(filename, "w");
    if(!fp2)
            MEM_ERROR;
            
    for(i = 0; i < size; i++)
    {        
          fputs(list[i], fp2);
          fputs("\n", fp2);
    }

    printf("\n\t%s has been created succesfully\n\n", filename);
    
    fclose(fp2);

    return;
}

I appreciate all feeback

Nevermind, I just fixed it by using gets ^_____^

Why are you passing in a pointer to a string for your filename when you could declare that locally?

Just a suggestion...

Code:

int saveFile (char** list, int size)
{    char filename[20];
     int i, length;
      
     // simpler prompt  (Operators hate unnecessary loquatiousness) 

     printf("Save As (15 characters, no numbers) :"); 
     if ( scanf("%15s", filename) < 1)
       return 0;  // return failure

     // append .txt if no extension provided
 
    if ( ! strchr(filename, '.'))
       strcat(filename, ".txt");
 
    fp2 = fopen(filename, "w");
    if(!fp2)
      return 0; // return failure
            
    for(i = 0; i < size; i++)
    {        
          fputs(list[i], fp2);
          fputs("\n", fp2);
    }

    fclose(fp2);
    printf("\n\t%s has been created succesfully\n", filename);
    return 1;  // return success
}

Glad it worked for you, but gets() is one of the most unsafe methods to get a user's input. Might be OK for your input, but never use it for a general user's input. They'll tear it to pieces.

Originally Posted by Adak

Glad it worked for you, but gets() is one of the most unsafe methods to get a user's input. Might be OK for your input, but never use it for a general user's input. They'll tear it to pieces.

You mean...

>>SaveAs ... "I want my file to be named 'the lost barber of Saville' backwards and in chinese, thank you very much"

LOL... I used to service systems in an office where one of the operators knew she could crash the system that way and would periodically type in invalid inputs to get a Friday afternoon off... at a cost to her employer of $220.00 per visit!