ok to return inside a for loop?

Apologies for the noob question here, but it's been a very long time since did any C.

can I just return a value from within a for loop to end loop execution or do I need to break and then return a value? Is this ok:

Code:

	int i;
	for(i = 0; i < upper_limit; i++){
		if (my_array[i] == val) {
			return i;
		}
	}

or must i do this?

Code:

	int i;
	for(i = 0; i < upper_limit; i++){
		if (my_array[i] == val) {
			break;
		}
	}
	if (i == upper_limit){
		return -1;
	} else {
		return i;
	}

First is right. You don't need a break here.

Of course you can. The for loop is just shorthand for:

Code:

#include <stdlib.h>
#include <stdio.h>

int main(int argc, char **argv)
{
    {
        int i = 20; // Initialize
        /* The loop */
        forloop1:
        printf("%d\n", i);
        /* The loop */
        if(!(i > 0)) goto forloop1end; // Check condition
        --i; // Iterate
        goto forloop1; // Loop
        forloop1end:
    }

    return EXIT_SUCCESS;
}

So inserting a return doesn't harm anything:

Code:

#include <stdlib.h>
#include <stdio.h>

int main(int argc, char **argv)
{
    {
        int i = 20; // Initialize
        /* The loop */
        forloop1:
        printf("%d\n", i);
        if(i == 5) return i;
        /* The loop */
        if(!(i > 0)) goto forloop1end; // Check condition
        --i; // Iterate
        goto forloop1; // Loop
        forloop1end:
    }

    return EXIT_SUCCESS;
}

Thanks guys. I'll be using this:

Code:

int i;
for(i = 0; i < upper_limit; i++){
    if (my_array[i] == val) {
        return i;
    }
}
return -1;