Thread: reading 2 ints and a char

Hello
I want to read 2 integers and 1 character. I have a function named input called from main.
The code I have is below. But when I check the values read I get different values, i.e

Enter value 1: 2
Enter char value 2: M
Enter value 3: 4
read values: 2293580 K 2293572

Code:

#include <stdio.h>
#include <string.h>  //not sure needed
#include <stdlib.h>  // not sure needed

void input(int* val1, char* val2, int* val3);

void main()
{
    int val1;       // value 1
    char val2;    // value 2
    int val3;          // value 3

    input(&val1, &val2, &val3);

    printf ("read values: %d %c %d", &val1, &val2, &val3);

}

void input(int* val1, char* val2, int* val3)
{
    //Input from the user
    printf ("Enter value 1: ");
    scanf ("%d", val1);
    printf ("Enter char value 2: ");
    scanf ("%s", val2);
    printf ("Enter value 3: ");
    scanf ("%d", val3);

}

I'm not returning any values in main. How should the values be sent back from the input function?

Thanks

I see what you mean. I removed the & signs from the printf statement on line 15. Now the values for the 2nd and 3rd values show correct but not the first one. Output for 1st value shows as 0 for some reason.

Thank you

I don't think so that there is need of pointers... remove the pointers and try diffrent variables of 2 ints and 1 char in void main block..

Originally Posted by Salem

> Output for 1st value shows as 0 for some reason.
And did you change
scanf ("%s", val2);
to
scanf (" %c", val2);

If you read a string, you're going to be trashing memory - like your int variables.

Salem
As soon as I replace the %s with a %c, the program does not accept a value for the second value. The output I get is:

Enter value 1: 7
Enter char value 2: Enter value 3: 5
read values: 7
5


Thanks

Originally Posted by DevoAjit

I don't think so that there is need of pointers... remove the pointers and try diffrent variables of 2 ints and 1 char in void main block..

If I remove the pointers, it seems to hang after I input the value 1. Thanks

Originally Posted by wearld97

Salem
As soon as I replace the %s with a %c, the program does not accept a value for the second value. The output I get is:

Enter value 1: 7
Enter char value 2: Enter value 3: 5
read values: 7
5


Thanks

Shouldn't the second variable be a character instead of a number?

Originally Posted by 7h3_0r4c1_3

Shouldn't the second variable be a character instead of a number?

Correct, but it doesn't wait to allow typing the 2nd value. Instead after displaying the line "Enter char value 2:"
For some reason it it immediately displays the line "Enter value 3:" on the same line.

Salem,
Do you mean to check on the space on line 25 before the %c? If yes, I did but it didn't help. Thanks.

Originally Posted by Salem

Post your latest code then please.

Here it is...Thanks

Code:

#include <stdio.h>
#include <string.h>  //not sure needed
#include <stdlib.h>  // not sure needed

void input(int* val1, char* val2, int* val3);

void main()
{
    int val1;       // value 1
    char val2;    // value 2
    int val3;          // value 3

    input(&val1, &val2, &val3);

    printf ("read values: %d %c %d", val1, val2, val3);

}

void input(int* val1, char* val2, int* val3)
{
    //Input from the user
    printf ("Enter value 1: ");
    scanf ("%d", val1);
    printf ("Enter char value 2: ");
    scanf ("%c", val2);
    printf ("Enter value 3: ");
    scanf ("%d", val3);

}