error while taking input using file

I'm using Dev-Cpp IDE.

I'd like to take input from a file. so, I wrote the following input function for my program.

Code:

int input (void)
{    
    int i, j;
    FILE* ip_file;
    
    ip_file = fopen("d:\sudoku_solver\input.txt","r+");
    for (i=0;i<size;i++)
    {
        for (j=0;j<size;j++)
        {
            fscanf(ip_file,"%d",&sudoku[i][j]);
            //copy to TempArr
            sudoku[i][j]==TempArr[i][j];
        }
    }
}// input()

my input file looks like this:

PHP Code:

000000000
000000000
000000000
000000000
000000000
000000000
000000000
000000000
000000000 


The problem is, when I compile the code. i am not getting errors but when I run.. the command prompt is closing saying "encountered error, needed to close"...

what shall I do.

This same happens when I take input file at command line.

Well, you should check the return value of fopen. It's possible you can't open the file for some reason (typo in the file name, permissions, etc). If fopen fails, it returns null, so you should print a useful error message and exit:

Code:

int input (void)
{    
    int i, j;
    FILE* ip_file;
     
    ip_file = fopen("d:\sudoku_solver\input.txt","r+");
    if (ip_file == NULL) {
        perror("Couldn't open input file");
        // return some error code
}

Also, you need to return an integer from input. Your compiler should be screaming at you for this. If not, turn the warnings all the way up. If you don't return an integer, you're in the realm of undefined behavior and anything could happen.

Your input file has no spaces or new lines in-between the 0s so

Code:

000000000 
000000000 
000000000 
000000000 
000000000 
000000000 
000000000 
000000000 
000000000
 

is not being translated as the amount of 0s you want. An integer is a number, not a digit. It's reading the entire line of 0s as one number. Space them out, or put each of them on separate lines.

Originally Posted by Rodaxoleaux

is not being translated as the amount of 0s you want. An integer is a number, not a digit. It's reading the entire line of 0s as one number. Space them out, or put each of them on separate lines.

Good catch.

@suryak: You should always check the return value of scanf. It will return the number of successful conversions. In your case, you only ask for one, "%d", so you would do:

Code:

if (fscanf(ip_file,"%d",&sudoku[i][j]) == 1) {
    //copy to TempArr
    sudoku[i][j]==TempArr[i][j];
}
else {
    perror("fscanf failed on input file");
    // return error
}

How is TempArr defined?
'==' is wrong here, it's a typical newbie mistake.

@anduiril462 : you are right! there is some error in opening the file.

This is my code..

Code:

    ip_file = fopen("D:\sudoku_solver\input.txt","r+");
    if (ip_file == NULL) 
    {
                perror ("couldn't open input file, please check addr\n");
                system("pause");
    }

actually, there is a file exactly and I verified the address but it still not able to take it..

this is error i am getting

PHP Code:

12:21 D:\sudoku_solver\io.c [Warning] unknown escape sequence '\s' 
12:21 D:\sudoku_solver\io.c [Warning] unknown escape sequence '\i' 


where the things might have been wrong

You need to escape the backslashes in your string literal, i.e., "D:\\sudoku_solver\\input.txt". Otherwise, it looks like an escape sequence for \s and \i instead of backslash character literals in a string literal.

Thanks.. problem is resolved.