Thread: Array problem averaging numbers

Originally Posted by Thedon

when compiled i get (a blank space) is less than the average 4.5 and so on

You are probably just misinterpreting your output because you insert a newline in a strange place. Try changing this:

Code:

printf("%d\n is less than average %f", array[i],average);

to:

Code:

printf("%d is less than average %f\n", array[i], average);

similiarly, change the printf for "greater than".

By the way, you should indent your code properly. It makes it easier to read and hence understand your program.

Better, but here is how I might format your code:

Code:

#include <stdio.h>

int main()
{
    int i, array[10] = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9,};
    float average, sum;
    average = sum = 0.0;

    i = 0;
    while (i < 10)
    {
        sum = sum + array[i];
        i++;
    }
    average = sum / i;
    printf("The average is %f\n", average);

    i = 0;
    while (i < 10)
    {
        if (array[i] > average) {
            printf("%d is greater than average %f\n", array[i], average);
            i++;
        }

        if (array[i] < average) {
            printf("%d is less than average %f\n", array[i], average);
            i++;
        }
    }

    return 0;
}

I have taken the liberty of moving the first i = 0; to just before the while loop that uses it. Also, I have added in the newlines as I demonstrates to make the output more readable. Other than that, your logic is entirely the same. Compile and run the program. You might notice something strange. Trace through the flow of control in your program to find out why it happens.

In particular, observe when you increment i in the second while loop. Are you doing it at the right place?

Originally Posted by Thedon

im pretty sure the second i is in the right place because it needs to be reset for the second loop.

I get an extra line of output because of that. The thing is, you only need to increment once in the loop, hence you should write:

Code:

    while (i < 10)
    {
        if (array[i] > average) {
            printf("%d is greater than average %f\n", array[i], average);
        }
 
        if (array[i] < average) {
            printf("%d is less than average %f\n", array[i], average);
        }
        i++;
    }