Thread: Trying to set two arrays which print out on one line

I'm trying to make this set two arrays each of 10 numbers, which are defined by the user, and then print out on one line.

Currently, it asks and stores the first 10, then asks the second but immediately prints a peculiar number.

What am I doing wrong?

Should I have two counts instead of one?

Code:

#include<stdio.h> 
void main()


{


int list[10];
int list1[10];
int count = 0;




printf("Enter 10 numbers:");


    while (count < 11)


        {
            
        scanf("%d", &list[count]);
        
        count++;
        
        break;
        
        }
        
printf("Enter a new set of 10 numbers:");
        
    while (count < 21)


        {
            
        scanf("%d", &list1[count]);
        
        count++;
        
        break;
        
        }
        
printf("%d%d", list, list1);
        
        
return;


}

You need to set the count variable to 0, before each of the loops. In C you nearly always want:

Code:

i=0;
while(i < 10)  //not <= 10, or < 11 array[10] is out of bounds
   scanf("%d",  &array[i]);

I like the idea of the while loop, but 80% of the time when there's a loop problem, changing over to a for loop, solves the problem. It makes you think more clearly about controlling the loop.

Code:

for (count = 0; count < 10; count ++)
    printf("%d ", list[count]);
puts("");
for (count = 0; count < 10; count ++)
    printf("%d ", list1[count]);

Code:

#include<stdio.h> void main()


{


int list[10];
int list1[10];
int count = 0;




printf("Enter 10 numbers:");


	while (count < 10)


		{
			
		scanf("%d", &list[count]);
		
		count++;
		
		break;
		
		}
		
printf("Enter a new set of 10 numbers:");
		
	count=0;


	while (count < 10)


		{
			
		scanf("%d", &list1[count]);
		
		count++;
		
		break;
		
		}
		
printf("%d%d", list, list1);
	
		
		
return;


}

Fader, I did follow your advice, please don't feel I ignored you, but it produced a similar problem so I kept my code like this with the count reset added. It still produces the same problem as before though, how come?

Originally Posted by King Mir

list and list1 aren't integers. You can't print them with %d. You need to loop through each index, and print it one by one, just like you're reading them.

Thanks, now it stores all twenty numbers but when it comes to print it shows a list of weird numbers (2000000 something). I got rid of my break; because I thought maybe they were causing difficulties?

Code:

#include<stdio.h> void main()


{


int list[10];
int list1[10];
int count = 0;




printf("Enter 10 numbers:");


	while (count < 10)


		{
			
		scanf("%d", &list[count]);
		
		count++;
		
		}
		
printf("Enter a new set of 10 numbers:");
		
	count=0;


	while (count < 10)


		{
			
		scanf("%d", &list1[count]);
		
		count++;
		
		}
		
	count=0;
	
	while (count < 10)


		{
			
		printf("%d ", &list[count]);
		
		count++;
		
		}
		
	
	count=0;


	while (count < 10)


		{
			
		printf("%d ", &list1[count]);
		
		count++;
		
		}
				
return;


}

No need for all that code:

Code:

#include<stdio.h> 


int main(void)
{
   int list[10];
   int list1[10];
   int count = 0;

   printf("Enter 20 numbers:\n");
   
   while (count < 10)
   {
	scanf("%d", &list[count]);
	count++;
   }
		
   printf("Enter a new set of 10 numbers:\n");
   count=0;
   while (count < 10)
   {
	scanf("%d", &list1[count]);
	count++;
   }
   count=0;
   while (count < 10)
   {
	printf("%d ", list[count]);
	count++;
   }
   count=0;
   while (count < 10)
   {
	printf("%d ", list1[count]);
	count++;
   }
   return 0;
}

Try that - no & in the printf()'s. Just in the scanf()'s.

That's great, thanks.