help with program

hey guys so i was doing what commontater said and i remade the program i was suppose to modify(not make). its working to an extent that it prints my error message even if the input is within the bounds. the program should print the correct statement if it is from a-z or A-Z anything else gets the error message except for the ";". i think the return(enter) key is making the error output even if the input is within the bounds. how do i make it ignore the return key as an error?

Code:

#include <stdio.h>


int main()
{
int ch;
	while((ch=getchar())!=EOF)
	{
		if((ch>='a' && ch<='z')||(ch>='A' && ch<='Z')&&(ch=='\r'))
		printf("The command is: %c\n",ch);
		else if(!(ch>='a' && ch<='z')||(ch>='A' && ch<='Z')
		{
		printf("Error: %c is not a letter.\n", ch);
		}
	}
}

Have you tried using using chr != '\n', instead of chr == '\r' ?

hey adak, thanks for the suggestion.
i have tried that and it does something similar to my current problem.
this is how i corrected it:
*also i was wondering if i should make another "if" statement and use that one for A-Z

Code:

#include <stdio.h>

int main()
{
int ch;
    while((ch=getchar())!=EOF)
    {
        if((ch>='a' && ch<='z')||(ch>='A' && ch<='Z')&&(ch!='\n'))
        printf("The command is: %c\n",ch);
        else if(!(ch>='a' && ch<='z')||(ch>='A' && ch<='Z'))
        {
        printf("Error: %c is not a letter.\n", ch);
        }
    }
}

The C standard doesn't know charactersets, only the '0'..'9' char-sequence is guaranteed.
Therefore your 'A'..'Z'/'a'..'z' code will crash if the actual characterset is not ASCII.

ok i kind of have an idea of what you meant but what does this have to do with crashing?

You could put another "else if" case to handle the newline.

hey thanks dude! that worked. if i wanted the program to print another message but the conditions are there must be a letter before a ';' like a ; b instead of ; b
is there a way to test if the first input is a letter?

Originally Posted by TheBigH

You could put another "else if" case to handle the newline.

To sample on what @BillyTKid said, you could use the "islower()" and "isupper()" standard functions instead. Just a suggestion.

EDIT: You need "#include <ctype.h>" for those.

i forgot to include the new code so here it is:

Code:

#include <stdio.h>




int main()
{
int ch;
	while((ch=getchar())!=EOF)
	{
		if((ch>='a' && ch<='z')||(ch>='A' && ch<='Z'))
		printf("The command is: %c\n",ch);
		else if(ch=='\n' || ch==';')
		{
		printf("");
		}
		else if(!(ch>='a' && ch<='z')||!(ch>='A' && ch<='Z'))
		{
		printf("Error: %c is not a letter.\n", ch);
		}
	}
}

I am not that familiar with those two functions but all i need is if I input the semicolon then a letter i want an error message to appear and then display the letter after that. sort of like instead of this: h;e which is okay, something like this ;i should make an error message because there should be a letter before the semicolon. been trying to implement different ifelse statements but they fail to a point where the program doesnt work normal. could you give me some advice?

Originally Posted by GReaper

To sample on what @BillyTKid said, you could use the "islower()" and "isupper()" standard functions instead. Just a suggestion.

EDIT: You need "#include <ctype.h>" for those.