Compilation error: how pass constants into function

Errors:
Attachment 11016
How can I pass constants into a function. I tried using ' ' but that also gave me error, so I removed them here.
Why does it say cell undeclared?
:(

Code:

---

#include<stdio.h>

#define MAX 80


void generate(int cell[], MAX);
void printArray(int cell[], MAX);


/*generate: current condition-->next generation
printArray: print 1 as *, 0 as <spacei>*/


int main(void)
{
    int cell[MAX]={0}, n, gen, i;


    printf("Enter starting location and number of generations: ");
    scanf("%d %d", &n, &gen);


    cell[n]=1;
    printArray(cell, MAX);
    for(i=2;i<=gen; i++)
    {
        generate(cell, MAX);
        printArray(cell, MAX);
    }
    return 0;
}
void generate(int cell[], MAX){
    int n=0;
    for (n=0; n<MAX; n++)
    if(!((cell[n+1]) && (cell[n-1])) && ((cell[n+1]) || (cell[n-1])))
        cell[n]=1;
        return;
}
   
void printArray(int cell[], MAX){
    int n;
    for (n=0; n<MAX; n++)
        if (cell[n]=1) printf ("*");
        if (cell[n]=0) printf (" ");
        else printf("!");
        printf("\n");
        return;
}

---

Code:

---

void generate(int cell[], MAX);
void printArray(int cell[], MAX);

---

Function arguments need types. You should be making something like:

Code:

---

void generate( int cell[], int size )
{
}
...
generate( cell, MAX );

---

Macros are just text replacement, so all your functions really just looked like:

Code:

---

void generate( int cell[], 80 )
{
}

---

Quzah.

line 6 ... void generate(int cell[], int cells);
line 32...

Code:

---

void generate(int cell[], int cells){
    int n=0;
    for (n=0; n< cells; n++)
    if(!((cell[n+1]) && (cell[n-1])) && ((cell[n+1]) || (cell[n-1])))
        cell[n]=1;
        return;
}

---

call as ... generate(cell,MAX); ...

Or since preprocessor values are global just use...

Code:

---

void generate(int cell[]){
    int n=0;
    for (n=0; n < MAX; n++)
    if(!((cell[n+1]) && (cell[n-1])) && ((cell[n+1]) || (cell[n-1])))
        cell[n]=1;
        return;
}

---

Thanks, the question prescribed the format, I don't know why :)

Quote:

---

Originally Posted by nanobot

Thanks, the question prescribed the format, I don't know why :)

---

Possibly to teach you this small lesson?

(It's just as important to know what does not work as what does.)

The code produces conway's pattern as required. My problem is, when I define MAX to 80, it no longer works. Why? :(

Code:

---

#include<stdio.h>

#define MAX 20


void generate(int cell[]);
void printArray(int cell[]);


/*generate: current condition-->next generation
printArray: print 1 as *, 0 as <spacei>*/


int main(void)
{
    int cell[MAX]={0}, n, gen, i;


    printf("Enter starting location and number of generations: ");
    scanf("%d %d", &n, &gen);


    cell[n]=1;
    printArray(cell);
    for(i=2;i<=gen; i++)
    {
        generate(cell);
        printArray(cell);
    }
    return 0;
}
void generate(int cell[]){
    int n=0;
    int copycell[MAX];
    for (n=0; n<MAX; n++) copycell[n]=cell[n];
   
    for (n=0; n<MAX; n++){
    if(!((copycell[n+1]) && (copycell[n-1])) && ((copycell[n+1]) || (copycell[n-1]))){
        cell[n]=1; }
        else cell[n]=0;
    }
        return;
}
   
void printArray(int cell[]){
    int n;
    for (n=0; n<MAX; n++)
        if (cell[n]==1) printf ("*");
        else if(cell[n]==0) printf (" ");
        else printf("!");
        printf("\n");
        return;
}

---

bump

Just so you know, saying "bump" is a really good way to turn people off helping you.

> if(!((copycell[n+1]) && (copycell[n-1])) && ((copycell[n+1]) || (copycell[n-1])))
When you're at the ends of the array, the +/-1 values are OUT OF BOUNDS.

> My problem is, when I define MAX to 80, it no longer works. Why?
It didn't work when it was 20 either.
It might have been producing the expected result, but it wasn't bug-free.