Quick Question about Strings

[givmefive5]

My program needs to have at least 15instructions with at most 70 string length. It should be declared inside a structure,

typedef char string70[71];

typedef struct{
string70 instruct[15];
}Recipe;
....
int main(){
Recipe x;
.....

fgets(x.instruct[1],sizeof(string70),stdin); /*Takes an inputed instruction*/
x.instruct[1][strlen(x.instruct[1])-1]= '\0'; /*Removes the extra enter key */

Is that the right code or.. Thank you )

[quzah]

Your typedef doesn't have a type. You need to define like so:

typedef typeofthing newnameofthing;

Your 'string70' doesn't have a type.


Quzah.

[givmefive5]

Edited that part, thanks

Is my program logically correct, the accessing of the last part to be null byte. thanks. )

[Adak]

Yes, but if you put it with an if statement, you avoid any problem with a long line that gets the newline truncated.

len = strlen(array[row]);
if(array[len-1]=='\n')
   array[len-1]='\0';

[CommonTater]

Yes, but if you put it with an if statement, you avoid any problem with a long line that gets the newline truncated.

len = strlen(array[row]);
if(array[len-1]=='\n')
   array[len-1]='\0';

Not to nit pick too badly but shouldn't that be ... array[row][len-1] = 0 ?

[laserlight]

My program needs to have at least 15instructions with at most 70 string length.

typedef char string70[71];

You fixed the syntax error that quzah pointed out, but there's a little more that you can do: give your type a better name. For example:

typedef char instruction_type[71];

/* ... */

instruction_type instructions[15];

This way, if your requirements change such that an instruction can have a max length of 80 instead, you would not end up either having to do some renaming, or having to live with a type named string70 that really means string80.

[givmefive5]

edited everything you guys said to my program, thank you )