HELP! How do I execute a function in a switch statement??

Assuming i already have a readImage function, how do i prompt the user to call it by typing in "Sailing"?

instructions:

1.3.1 Load a PPM Image
This option prompts the user for the name of an image file. You don't have to implement a file reading
function; just use the provided one, ReadImage. Once option 1 is selected, the following should be shown:
Please input the file name to load: sailing
After a name, for example sailing, is entered, the PhotoLab will load the file sailing.ppm. Note that, in
this assignment please always enter file names without the extension when you load or save a file (i.e. enter
'sailing', instead of 'sailing.ppm'). If it is read correctly, the following is shown:
Please make your choice: 1
Please input the file name to load: sailing
sailing.ppm was read successfully!
--------------------------------
1: Load a PPM image
2: Save an image in PPM and JPEG format
3: Change a color image to black and white
4: Make a negative of an image
5: Flip an image horizontally
2
6: Mirror an image horizontally
7: Flip an image vertically
8: Mirror an image vertically
9: Test all functions
10: Exit
Please make your choice:
Then, you can select other options. If there is a reading error, for example the file name is entered incorrectly
or the file does not exist, the following message is shown:
Cannot open file "sailing.ppm.ppm" for reading!


This is what i have so far i dont know how to use a switch statement to call the function readImage becuase I already have a printf statement in it. HELP

Code:

---

int main(void)
{
        int c;
        char name;

        do
        {
                printf("1: Load a PPM image\n");
                printf("2: Save an image in PPM and JPEG format\n");
                printf("3: Change a color image to black and white\n");
                printf("4: Make a negative of an image\n");
                printf("5: Flip an image horizontally\n");
                printf("6: Mirror an image vertically\n");
                printf("7: Flip an image vertically\n");
                printf("8: Mirror an image vertically\n");
                printf("9: Test all functions\n");
                printf("10: Exit\n");
                printf("Please make your choice: \n");
                scanf("%d",&c);
       

                switch(c)
                {
                case 1:
                        printf("Please input the file name to load: \n");
                        scanf("%s",name);
                        readImage?
                               
                        break;
                }
        }

---

Does the readImage function take an argument such as the file name to be loaded/read? If so then you'd need to pass the file name to the function so that it can process that particular file. I'm guessing you'd want to pass the name variable to the readImage function.

On the topic of the name variable, a single char is not enough to store a file name. You need to make name an array of sufficient size.

I am not really sure what your question is exactly? If you want to call readImage from within the switch statement, just call it like you would call any other function. A mistake in your code is also that you are trying to read a string into a single char variable. You must change char name into either a pointer to a char, and allocate memory for the string, or change it to a char array. You should also make sure that the user doesn't enter a filename which is longer than your filename buffer can hold.

This is my readImage function: (which is given)

I just need to know how to call it in my switch function, so when the user types in "Sailing" it loads the Picture from the file.

Code:

---

/*Three function definitions are provided:ReadImage, ReadImageW, SaveImage*/
int
ReadImage(char fname[SLEN], unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT])
{
        FILE          *File;
        char            Type[SLEN];
        int            Width, Height, MaxValue;
        int            x, y;
        char            ftype[] = ".ppm";
        char            fname_tmp[SLEN];  /*avoid to modify on the original pointer, 11/10/10, X.Han*/

        strcpy(fname_tmp, fname);
        strcat(fname_tmp, ftype);

        File = fopen(fname_tmp, "r");
        if (!File) {
                printf("\nCannot open file \"%s\" for reading!\n", fname);
                return 1;
        }
        fscanf(File, "%79s", Type);
        if (Type[0] != 'P' || Type[1] != '6' || Type[2] != 0) {
                printf("\nUnsupported file format!\n");
                return 2;
        }
        fscanf(File, "%d", &Width);
        if (Width != WIDTH) {
                printf("\nUnsupported image width %d!\n", Width);
                return 3;
        }
        fscanf(File, "%d", &Height);
        if (Height != HEIGHT) {
                printf("\nUnsupported image height %d!\n", Height);
                return 4;
        }
        fscanf(File, "%d", &MaxValue);
        if (MaxValue != 255) {
                printf("\nUnsupported image maximum value %d!\n", MaxValue);
                return 5;
        }
        if ('\n' != fgetc(File)) {
                printf("\nCarriage return expected!\n");
                return 6;
        }
        for (y = 0; y < HEIGHT; y++)
                for (x = 0; x < WIDTH; x++) {
                        R[x][y] = fgetc(File);
                        G[x][y] = fgetc(File);
                        B[x][y] = fgetc(File);
                }
        if (ferror(File)) {
                printf("\nFile error while reading from file!\n");
                return 7;
        }
        printf("%s was read successfully!\n", fname_tmp);
        fclose(File);
        return 0;
}

---

What do i put in the bold?

Code:

---

int main(void)
{
    int c;
    char name;
 
    do
    {
        printf("1: Load a PPM image\n");
        printf("2: Save an image in PPM and JPEG format\n");
        printf("3: Change a color image to black and white\n");
        printf("4: Make a negative of an image\n");
        printf("5: Flip an image horizontally\n");
        printf("6: Mirror an image vertically\n");
        printf("7: Flip an image vertically\n");
        printf("8: Mirror an image vertically\n");
        printf("9: Test all functions\n");
        printf("10: Exit\n");
        printf("Please make your choice: \n");
        scanf("%d",&c);
   
 
        switch(c)
        {
        case 1:
            printf("Please input the file name to load: \n");
            scanf("%s",name);
            How do i call readImage function when Sailing is entered?? what do i put here to call it??
            break;
        }
    }

---

Quote:

---

Originally Posted by kkmoslehpour

What do i put in the bold?

---

Just the function call, there is no magic to it. You are already calling a function earlier in your program, printf(), you just do the same with ReadImage(name, ...). You just need to pass the filename and the rest of the arguments to it.

And don't forget to change name from char name; to char name[XX] where XX is the max number of letters (-1 for the null termination) in the filename.

Quote:

---

Originally Posted by iceaway

Just the function call, there is no magic to it. You are already calling a function earlier in your program, printf(), you just do the same with ReadImage(name, ...). You just need to pass the filename and the rest of the arguments to it.

And don't forget to change name from char name; to char name[XX] where XX is the max number of letters (-1 for the null termination) in the filename.

---

Like this?
but then Sailing becomes unidentified then...

Code:

---

switch(choice)
                {
                case 1:
                        printf("Please input the file name to load: \n");
                        scanf("%s",name);
                        if(fileName==sailing)
                                ReadImage();

---

Quote:

---

Originally Posted by kkmoslehpour

Like this?
but then Sailing becomes unidentified then...

Code:

---

switch(choice)
        {
        case 1:
            printf("Please input the file name to load: \n");
            scanf("%s",name);
            if(fileName==sailing)
                ReadImage();

---

---

You cannot compare strings (char arrays) like that in C. You have to do:

Code:

---

if (strcmp(fileName, "sailing") == 0) {
    /* fileName is equal to sailing, do stuff */
}

---

Also, your ReadImage expects some more arguments, the filename and the R, G, B two-dimensional arrays.

sorry i didnt give you the complete code all the file names are already defined. Here is all the complete code...

can you check if my case 1 is correct?

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

/*** global definitions ***/
#define WIDTH  640                /* Image width */
#define HEIGHT 425                /* image height */
#define SLEN    80                /* maximum length of file names */
/*** function declarations ***/

/* print a menu */
void            PrintMenu();

/* read image from a file */
int            ReadImage(char fname[SLEN], unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT]);

/* save a processed image */
int            SaveImage(char fname[SLEN], unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT]);

/* change color image to black & white */
void            BlackNWhite(unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT]);

/* reverse image color */
void            Negative(unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT]);

/* flip image horizontally */
void            HFlip(unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT]);

/* mirror image horizontally */
void            HMirror(unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT]);

/* flip image vertically */
void            VFlip(unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT]);

/* mirror image vertically */
void            VMirror(unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT]);

/* Test all functions */
void            AutoTest(unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT]);


/*define your main function here*/


int main(void)
{
        int choice;
        char fileName [10];

        do
        {
                printf("1: Load a PPM image\n");
                printf("2: Save an image in PPM and JPEG format\n");
                printf("3: Change a color image to black and white\n");
                printf("4: Make a negative of an image\n");
                printf("5: Flip an image horizontally\n");
                printf("6: Mirror an image vertically\n");
                printf("7: Flip an image vertically\n");
                printf("8: Mirror an image vertically\n");
                printf("9: Test all functions\n");
                printf("10: Exit\n");
                printf("Please make your choice: \n");
                scanf("%d",&choice);
       

                switch(choice)
                {
                case 1:
                        printf("Please input the file name to load: \n");
                        scanf("%s",fileName);
                        if (strcmp(fileName, "sailing") == 0)
                                { int returnCode = readImage(fileName, imageR, imageG, imageB);} // is that what you meant?


    /* fileName is equal to sailing, do stuff */
}
                case 2:
                        printf("please enter the file name to be saved \n");
                        scanf("%s",fileName);
                case 3:
                        printf("Black & White operation is done! \n");

                               
                        break;
                }
        }


/*Three function definitions are provided:ReadImage, ReadImageW, SaveImage*/
int
ReadImage(char fname[SLEN], unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT])
{
        FILE          *File;
        char            Type[SLEN];
        int            Width, Height, MaxValue;
        int            x, y;
        char            ftype[] = ".ppm";
        char            fname_tmp[SLEN];  /*avoid to modify on the original pointer, 11/10/10, X.Han*/

        strcpy(fname_tmp, fname);
        strcat(fname_tmp, ftype);

        File = fopen(fname_tmp, "r");
        if (!File) {
                printf("\nCannot open file \"%s\" for reading!\n", fname);
                return 1;
        }
        fscanf(File, "%79s", Type);
        if (Type[0] != 'P' || Type[1] != '6' || Type[2] != 0) {
                printf("\nUnsupported file format!\n");
                return 2;
        }
        fscanf(File, "%d", &Width);
        if (Width != WIDTH) {
                printf("\nUnsupported image width %d!\n", Width);
                return 3;
        }
        fscanf(File, "%d", &Height);
        if (Height != HEIGHT) {
                printf("\nUnsupported image height %d!\n", Height);
                return 4;
        }
        fscanf(File, "%d", &MaxValue);
        if (MaxValue != 255) {
                printf("\nUnsupported image maximum value %d!\n", MaxValue);
                return 5;
        }
        if ('\n' != fgetc(File)) {
                printf("\nCarriage return expected!\n");
                return 6;
        }
        for (y = 0; y < HEIGHT; y++)
                for (x = 0; x < WIDTH; x++) {
                        R[x][y] = fgetc(File);
                        G[x][y] = fgetc(File);
                        B[x][y] = fgetc(File);
                }
        if (ferror(File)) {
                printf("\nFile error while reading from file!\n");
                return 7;
        }
        printf("%s was read successfully!\n", fname_tmp);
        fclose(File);
        return 0;
}

int
SaveImage(char fname[SLEN], unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT])
{
        FILE          *File;
        int            x, y;
        char            SysCmd[SLEN * 5];

        char            ftype[] = ".ppm";
        char            fname_tmp[SLEN];  /*avoid to modify on the original pointer, 11/10/10, X.Han*/
        char            fname_tmp2[SLEN];

        strcpy(fname_tmp, fname);
        strcpy(fname_tmp2, fname);
        strcat(fname_tmp2, ftype);

        File = fopen(fname_tmp2, "w");
        if (!File) {
                printf("\nCannot open file \"%s\" for writing!\n", fname);
                return 1;
        }
        fprintf(File, "P6\n");
        fprintf(File, "%d %d\n", WIDTH, HEIGHT);
        fprintf(File, "255\n");

        for (y = 0; y < HEIGHT; y++)
                for (x = 0; x < WIDTH; x++) {
                        fputc(R[x][y], File);
                        fputc(G[x][y], File);
                        fputc(B[x][y], File);
                }

        if (ferror(File)) {
                printf("\nFile error while writing to file!\n");
                return 2;
        }
        fclose(File);
        printf("%s was saved successfully. \n", fname_tmp2);

        /*
        * rename file to image.ppm, convert it to ~/public_html/<fname>.jpg
        * and make it world readable
        */
        sprintf(SysCmd, "/users/grad2/doemer/eecs22/bin/pnmtojpeg.tcsh %s",
                fname_tmp2);
        if (system(SysCmd) != 0) {
                printf("\nError while converting to JPG:\nCommand \"%s\" failed!\n", SysCmd);
                return 3;
        }
        printf("%s.jpg was stored for viewing. \n", fname_tmp);

        return (0);
}

/*define all other functions here*/

---

Looks better, but there are some warnings when compiling it, you don't get any warnings? You need to use break; in your switch-statements after each case (otherwise they will "fall through"), and you have one too many }, just at the end of case 1.

I can't see imageR/G/B declared anywhere in your code. You have to declare those. You should probably increase the length of the filename variable a bit, most of us use filenames with more than 9 letters occasionally :-) And make sure that you don't write past the array length if the user should enter something which is too long.

Quote:

---

Originally Posted by iceaway

Looks better, but there are some warnings when compiling it, you don't get any warnings? You need to use break; in your switch-statements after each case (otherwise they will "fall through"), and you have one too many }, just at the end of case 1.

I can't see imageR/G/B declared anywhere in your code. You have to declare those. You should probably increase the length of the filename variable a bit, most of us use filenames with more than 9 letters occasionally :-) And make sure that you don't write past the array length if the user should enter something which is too long.

---

okay im kind of getting this little by little.... thanks for being patient :D

Here is the question:

Are my imageR, imageG, imageB considered as a char? or int? because when i declare it as a char it doesn't like it...

never mind i think this is how i do it?

okay so i have this in my main so far, how does it look?


also i am not used to compiling it in little sections.. i usually code the whole thing then compile it, because i am afraid of errors and warnings.... :(

Code:

---

int main(void)
{
        int choice;
        char fileName [100];
        unsigned char imageR[WIDTH][HEIGHT];
        unsigned char imageG[WIDTH][HEIGHT];
        unsigned char imageB[WIDTH][HEIGHT];
        do
        {
                printf("1: Load a PPM image\n");
                printf("2: Save an image in PPM and JPEG format\n");
                printf("3: Change a color image to black and white\n");
                printf("4: Make a negative of an image\n");
                printf("5: Flip an image horizontally\n");
                printf("6: Mirror an image vertically\n");
                printf("7: Flip an image vertically\n");
                printf("8: Mirror an image vertically\n");
                printf("9: Test all functions\n");
                printf("10: Exit\n");
                printf("Please make your choice: \n");
                scanf("%d",&choice);
       

                switch(choice)
                {
                case 1:
                        printf("Please input the file name to load: \n");
                        scanf("%s",fileName);
                        if (strcmp(fileName, "sailing") == 0)
                        {
                                int returnCode = ReadImage(fileName, imageR, imageG, imageB);
                        }
                        break;
                case 2:
                        printf("please enter the file name to be saved \n");
                        scanf("%s",fileName);
                        break;
                case 3:
                        printf("Black & White operation is done! \n");       
                        break;
                }
        }

---

Im getting all these errors =[

Error 4 error C2062: type 'int' unexpected c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 97
Error 5 error C2143: syntax error : missing ';' before '{' c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 98
Error 6 error C2065: 'fname' : undeclared identifier c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 106
Error 7 error C2065: 'fname' : undeclared identifier c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 111
Error 8 error C2065: 'R' : undeclared identifier c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 140
Error 9 error C2065: 'G' : undeclared identifier c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 141
Error 10 error C2065: 'B' : undeclared identifier c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 142
Error 11 error C2601: 'SaveImage' : local function definitions are illegal c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 155
Error 12 error C1075: end of file found before the left brace '{' at 'c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp(51)' was matched c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 207
13 IntelliSense: expected 'while' c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 97
14 IntelliSense: expected a '(' c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 151

Quote:

---

Originally Posted by kkmoslehpour

Im getting all these errors =

---

Now is as good a time as any to start learning how to fix your own problems.

"But how do I do that!? Programming is so HARRRDDDDD!!

How about taking one at a time?

"But what one there are so manyyyyy?!!!"

Just like your compiler, take the top one and work your way down. Fix one, compile. Repeat until done:

Quote:

---

Originally Posted by kkmoslehpour

Error 4 error C2062: type 'int' unexpected c:\users\kmoslehp\documents\visual studio 2010\projects\asdfsfsf\asdfsfsf\hw2.cpp 97

---

Go hang out around line 97 and see what you've done wrong.


Quzah.

I know i can read it, the only problem is I dont know what to change to fix the problem, since my code is so long..... Im afraid if i change something something else would go wrong...

Quote:

---

Originally Posted by kkmoslehpour

I know i can read it, the only problem is I dont know what to change to fix the problem, since my code is so long..... Im afraid if i change something something else would go wrong...

---

Stop whining and take the task as a challenge... It's a puzzle, you can solve it.

Quote:

---

Originally Posted by kkmoslehpour

I know i can read it, the only problem is I dont know what to change to fix the problem, since my code is so long..... Im afraid if i change something something else would go wrong...

---

Fortunately for us, programming isn't a one-chance deal. If it doesn't work, change it and recompile.


Quzah.

Quote:

---

Originally Posted by kkmoslehpour

I know i can read it, the only problem is I dont know what to change to fix the problem, since my code is so long..... Im afraid if i change something something else would go wrong...

---

And what can we learn from this? Never write large chunks of code without testing it in small steps! :-) Writing several hundred lines of code and then troubleshooting it is a lot more difficult and error prone than doing it in smaller portions.

Please repost your code as it is now, along with the compiler errors so we can see which lines of code they correspond to. But I strongly suggest you look at the error messages yourself first, and try to work each one out. Try googling for the specific error messages, that can usually give you some good ideas if you are clueless as to what it means.

> i usually code the whole thing then compile it, because i am afraid of errors and warnings....
Well that's an absolutely GUARANTEED way of getting page after page after page of disheartening error messages that take ages to solve.
You're doing it wrong!

The compiler is your friend and guide for the journey, not some harsh gatekeeper preventing you from making progress.

http://cboard.cprogramming.com/c-pro...t-process.html
If you only write a few lines and then press compile, then the most likely outcome is it either compiles or you get just a couple of errors.
Two errors, plus fresh code is very easy to fix.

100+ errors, plus "WTF was I thinking when I wrote that" code is far harder to fix.

Also, when you've finished writing a section of code (say a menu + input), you actually RUN THE CODE to make sure it works. It might not seem like it to you, but getting code to compile is actually pretty damn easy. Getting it to do exactly what you want is the real trick.

Quote:

---

Originally Posted by Salem

100+ errors, plus "WTF was I thinking when I wrote that" code is far harder to fix.

---

Another reason I like Pelles C... it has a cute bit of humour built in... When it hits the MAX_ERRORS wall, it stops and prints out a warning: "More than 200 errors, please improver yourself" .... The first time I saw that I was right on the floor laughing!

Compiler as teacher... ok.

okay, thanks, i fix the do while loop problem. But why am i getting these other errors, it is saying i didn't define my variable (error message 8~17), and all the other variables when it is defined. Also how do i have a function within a function. I searched up the error messages 4 and 5 and I dont know how I have local definitions.

Error 4 error C2601: 'ReadImage' : local function definitions are illegal c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 110 1 asfsafasf
Error 5 error C2601: 'SaveImage' : local function definitions are illegal c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 167 1 asfsafasf
Error 6 error C1075: end of file found before the left brace '{' at 'c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfa sfasfas.cpp(51)' was matched c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 218 1 asfsafasf
7 IntelliSense: expected a ';' c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 110 1 asfsafasf
8 IntelliSense: identifier "Width" is undefined c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 132 6 asfsafasf
9 IntelliSense: identifier "File" is undefined c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 136 9 asfsafasf
10 IntelliSense: identifier "Height" is undefined c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 136 22 asfsafasf
11 IntelliSense: identifier "MaxValue" is undefined c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 141 22 asfsafasf
12 IntelliSense: identifier "y" is undefined c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 150 7 asfsafasf
13 IntelliSense: identifier "x" is undefined c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 151 8 asfsafasf
14 IntelliSense: identifier "R" is undefined c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 152 4 asfsafasf
15 IntelliSense: identifier "G" is undefined c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 153 4 asfsafasf
16 IntelliSense: identifier "B" is undefined c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 154 4 asfsafasf
17 IntelliSense: identifier "fname_tmp" is undefined c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 160 40 asfsafasf

So i am getting red underlines for my width height fname.. etc but it is defined on top... i dont get it..

Code:

---

int ReadImage(char fname[SLEN], unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT])
{
        FILE          *File;
        char            Type[SLEN];
        int            Width, Height, MaxValue;
        int            x, y;
        char            ftype[] = ".ppm";
    char            fname_tmp[SLEN];  /*avoid to modify on the original pointer, 11/10/10, X.Han*/

        strcpy(fname_tmp, fname);
        strcat(fname_tmp, ftype);

        File = fopen(fname_tmp, "r");
        if (!File) {
                printf("\nCannot open file \"%s\" for reading!\n", fname);
                return 1;
        }
        fscanf(File, "%79s", Type);
        if (Type[0] != 'P' || Type[1] != '6' || Type[2] != 0) {
                printf("\nUnsupported file format!\n");
                return 2;
        }
        fscanf(File, "%d", &Width);
        if (Width != WIDTH) {
                printf("\nUnsupported image width %d!\n", Width);
                return 3;
        }
        fscanf(File, "%d", &Height);
        if (Height != HEIGHT) {
                printf("\nUnsupported image height %d!\n", Height);
                return 4;
        }
        fscanf(File, "%d", &MaxValue);
        if (MaxValue != 255) {
                printf("\nUnsupported image maximum value %d!\n", MaxValue);
                return 5;
        }
        if ('\n' != fgetc(File)) {
                printf("\nCarriage return expected!\n");
                return 6;
        }
        for (y = 0; y < HEIGHT; y++)
                for (x = 0; x < WIDTH; x++) {
                        R[x][y] = fgetc(File);
                        G[x][y] = fgetc(File);
                        B[x][y] = fgetc(File);
                }
        if (ferror(File)) {
                printf("\nFile error while reading from file!\n");
                return 7;
        }
        printf("%s was read successfully!\n", fname_tmp);
        fclose(File);
        return 0;

---

Post your latest code.

Quote:

---

Originally Posted by kkmoslehpour

Error 4 error C2601: 'ReadImage' : local function definitions are illegal c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 110 1 asfsafasf
Error 5 error C2601: 'SaveImage' : local function definitions are illegal c:\users\dshang1\desktop\asfsafasf\asfsafasf\asfas fasfas.cpp 167 1 asfsafasf

---

Sounds like you have a function inside a function, which you can't do:

Code:

---

void foo( void )
{
    void bar( void )  /* you can't create a function inside a function */
    {
    }
}

---

Which is typically caused by something like:

Code:

---

void foo( void )
{
    ...stuff for foo
...end of stuff for foo
/* oops, forgot my } */

void bar( void )  /* your compiler thinks this is in foo, because you for */
{
    ...stuff for bar
}

---

Quzah.

Quote:

---

Originally Posted by quzah

Post your latest code.Sounds like you have a function inside a function, which you can't do:

Code:

---

void foo( void )
{
    void bar( void )  /* you can't create a function inside a function */
    {
    }
}

---

Which is typically caused by something like:

Code:

---

void foo( void )
{
    ...stuff for foo
...end of stuff for foo
/* oops, forgot my } */

void bar( void )  /* your compiler thinks this is in foo, because you for */
{
    ...stuff for bar
}

---

Quzah.

---

Thanks so much !! :D

Everything is solved but now im getting this... unresolved path? Does this mean it can't located the file to load?



Error 1 error LNK2019: unresolved external symbol _WinMain@16 referenced in function ___tmainCRTStartup C:\Users\dshang1\Desktop\asfsafasf\asfsafasf\MSVCR TD.lib(crtexew.obj) asfsafasf
Error 2 error LNK1120: 1 unresolved externals C:\Users\dshang1\Desktop\asfsafasf\Debug\asfsafasf .exe 1 1 asfsafasf

Do you actually have a main function in your program? You have to have one, it's where your program starts.


Quzah.

I have an int main ()
when i do void main () what should i write in the main function to start the program

Quote:

---

Originally Posted by your errors

Error 1 error LNK2019: unresolved external symbol _WinMain@16 referenced in function ___tmainCRTStartup C:\Users\dshang1\Desktop\asfsafasf\asfsafasf\MSVCR TD.lib(crtexew.obj) asfsafasf

---

You receive an "unresolved external symbol _WinMain@16" error message when you try to build an MFC application with Unicode support in Visual C++
You receive an "error LNK2001:unresolved external symbol "_WinMain@16" message when a Console Application project is built as an Application project in Visual C++

A couple of seconds and a search engine should set you straight.


Quzah.

thanks again! ill be coming with more questions! :D

here is my save image function (case 2), it builds successfully, but i get a message in the output saying that it cannot find the path specified


Is this right?


My code:

Code:

---

int main(void)
{
        int choice;
        int done = 0;
        char fileName [100];
        unsigned char imageR[WIDTH][HEIGHT];
        unsigned char imageG[WIDTH][HEIGHT];
        unsigned char imageB[WIDTH][HEIGHT];

        do
        {
                printf("1: Load a PPM image\n");
                printf("2: Save an image in PPM and JPEG format\n");
                printf("3: Change a color image to black and white\n");
                printf("4: Make a negative of an image\n");
                printf("5: Flip an image horizontally\n");
                printf("6: Mirror an image vertically\n");
                printf("7: Flip an image vertically\n");
                printf("8: Mirror an image vertically\n");
                printf("9: Test all functions\n");
                printf("10: Exit\n");
                printf("Please make your choice: ");
                scanf("%d",&choice);
       

                switch(choice)
                {
                case 1:
                        printf("Please input the file name to load: ");
                        scanf("%s",fileName);
                        if (strcmp(fileName, "sailing") == 0)
                        {
                                int returnCode = ReadImage(fileName, imageR, imageG, imageB);
                        }
                        else
                        {
                                printf("Cannot open file ''%s'' for reading!\n\n",fileName);
                        }
                        break;

                case 2:
                        printf("please enter the file name to be saved: ");
                        scanf("%s",fileName);
                        {
                                int returnCode = SaveImage(fileName, imageR, imageG, imageB);
                        }
                        printf("''%s'' was saved successfully.",fileName);
                        printf("''%s'' was stored for viewing.",fileName);
                        break;

                case 3:
                        printf("Black & White operation is done! \n");       
                        break;

                case 10:
                        printf("Exit \n");
                        done = 1;
                        break;

                default:
                        printf("Invalid choice!\n");
            break;
                }
        }
        while(!done);
}

---

Save Image Function(given):

Code:

---

int SaveImage(char fname[SLEN], unsigned char R[WIDTH][HEIGHT], unsigned char G[WIDTH][HEIGHT], unsigned char B[WIDTH][HEIGHT])
{
        FILE          *File;
        int            x, y;
        char            SysCmd[SLEN * 5];
        char            ftype[] = ".ppm";
        char            fname_tmp[SLEN];  /*avoid to modify on the original pointer, 11/10/10, X.Han*/
    char            fname_tmp2[SLEN];

        strcpy(fname_tmp, fname);
        strcpy(fname_tmp2, fname);
        strcat(fname_tmp2, ftype);

        File = fopen(fname_tmp2, "w");
        if (!File) {
                printf("\nCannot open file \"%s\" for writing!\n", fname);
                return 1;
        }
        fprintf(File, "P6\n");
        fprintf(File, "%d %d\n", WIDTH, HEIGHT);
        fprintf(File, "255\n");

        for (y = 0; y < HEIGHT; y++)
                for (x = 0; x < WIDTH; x++) {
                        fputc(R[x][y], File);
                        fputc(G[x][y], File);
                        fputc(B[x][y], File);
                }

        if (ferror(File)) {
                printf("\nFile error while writing to file!\n");
                return 2;
        }
        fclose(File);
        printf("%s was saved successfully. \n", fname_tmp2);

        /*
        * rename file to image.ppm, convert it to ~/public_html/<fname>.jpg
        * and make it world readable
        */
        sprintf(SysCmd, "/users/grad2/doemer/eecs22/bin/pnmtojpeg.tcsh %s",
                fname_tmp2);
        if (system(SysCmd) != 0) {
                printf("\nError while converting to JPG:\nCommand \"%s\" failed!\n", SysCmd);
                return 3;
        }
        printf("%s.jpg was stored for viewing. \n", fname_tmp);

        return (0);
}

---

Instructions:

1.3.2 Save a PPM Image
This option prompts the user for the name of the target image file. You don't have to implement a file saving
function; just use the provided one, SaveImage. Once option 2 is selected, the following is shown:
Please make your choice: 2
Please input the file name to save: bw
bw.ppm was saved successfully.
bw.jpg was stored for viewing.
--------------------------------
1: Load a PPM image
2: Save an image in PPM and JPEG format
3: Change a color image to black and white
4: Make a negative of an image
5: Flip an image horizontally
6: Mirror an image horizontally
7: Flip an image vertically
8: Mirror an image vertically
9: Test all functions
10: Exit
Please make your choice:
The saved image will be automatically converted to a JPEG image and sent to the folder public html. You
then are able to see the image at: http://newport.eecs.uci.edu/youruserid (For o campus, the link is:
http://newport.eecs.uci.edu/youruserid/imagename.jpg)

I assume you mean that your system call is telling you it can't find this: /users/grad2/doemer/eecs22/bin/pnmtojpeg.tcsh

Because none of your other error messages you have in there match what you say you are getting. So make sure you can actually run pnmtojpg.tcsh from your shell manually.


Quzah.

I dont get it. I need to access this file remotely, and this file for sure exist, because it loads. I don't know why I am getting this output when i save it. help me out here :(


1: Load a PPM image
2: Save an image in PPM and JPEG format
3: Change a color image to black and white
4: Make a negative of an image
5: Flip an image horizontally
6: Mirror an image vertically
7: Flip an image vertically
8: Mirror an image vertically
9: Test all functions
10: Exit
Please make your choice: 1
Please input the file name to load: sailing
sailing.ppm was read successfully!

1: Load a PPM image
2: Save an image in PPM and JPEG format
3: Change a color image to black and white
4: Make a negative of an image
5: Flip an image horizontally
6: Mirror an image vertically
7: Flip an image vertically
8: Mirror an image vertically
9: Test all functions
10: Exit
Please make your choice: 2
please enter the file name to be saved: bw
bw.ppm was saved successfully.
The system cannot find the path specified.

Error while converting to JPG:
Command "/users/grad2/doemer/eecs22/bin/pnmtojpeg.tcsh bw.ppm" failed!
''bw'' was saved successfully.''bw'' was stored for viewing.
1: Load a PPM image
2: Save an image in PPM and JPEG format
3: Change a color image to black and white
4: Make a negative of an image
5: Flip an image horizontally
6: Mirror an image vertically
7: Flip an image vertically
8: Mirror an image vertically
9: Test all functions
10: Exit
Please make your choice:

So did you do what I suggested, or am I just typing to hear my keyboard clack?


Quzah.

im pretty new to this so im not sure how to run that...

Open up your shell and type in that line. See if it gives you a bad command / file name type error. If it does, then either you don't have that program, or you don't have permission to run that program, so your program isn't going to work.


Quzah.