Following is a simple code which is supposed to remove all vowels from the supplied string, which is not more than 80 bytes. But it is removing few other alphabets other than vowels. Can anyone tell me wat's wrong??
Could '\b' not be used to for storing a backspace..
Code:void main() { char *p,*t; t=p=(char *)malloc(80); gets(p); while(*p) { if(*p=='A'|| *p=='E' || *p=='I' || *p=='O' || *p=='U'|| *p=='a' || *p=='e' || *p=='i' || *p=='o' || *p=='u') *p='\b'; p++; } puts(t); getch(); }
If you aren't going to make a copy of the string, and it looks like you aren't, then you should try overwriting the vowels you find, or something else. Using \b is on the wrong track. \b is a special character that only moves the cursor back once, it doesn't mean backspace. The backspace you use everyday is actually programmed in to work like that.
I note that instead of removing vowels, you replace them with '\b'.
A few other things to note:
- Include the appropriate headers.
- The return type of main is int, not void.
- There is no need to cast the return value of malloc.
- Do not use gets. Use fgets or some other safer alternative.
- free what you malloc
- There probably is no need to use getch.
Look up a C++ Reference and learn How To Ask Questions The Smart WayOriginally Posted by Bjarne Stroustrup (2000-10-14)
\b does not really remove anything from your string. It is a terminal escape code, which alters the way a string is shown in terminal. It does not however remove any characters from your string. If you want to remove a character, then you need to actually move all other characters backwards to replace the character that is removed. Your assignment just got a bit more complicated
Obsession to networking and protocols made me cook up these:
NSN - Network Status Notifier
epb - Ethernet Packet Bombardier
T.H.O.N.G.S - Textmode Helper On Network Getting Sniffed
Nibbles - console UDP print listener/filter + something else
Feel free to try, comment and improve =)
Is that what the OS (or any basic word or notepad program) does when we hit 'Delete' or 'Backspace', or does it perform some other procedure?
Last edited by juice; 09-26-2011 at 03:46 AM.
It performs some other procedure that does not primarily involve removing characters from a string. Basically, you're on the wrong track if you're talking about the OS. Just think in terms of the algorithm at hand.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
You want to shift all the subsequent letters up to overwrite each vowel in the string?
If so, don't use a replacement char , do it "low level", by actually shifting the char's, in the array, in the program.
Hint: With each vowel you find, the subsequent shift becomes one char larger: ++gap.
I mean, after the first vowel, you need to shift the subsequent char's by one char, in the string - but after the second vowel you find, you need to shift the subsequent char's, by two chars. With every vowel you find, the gap you have to shift, becomes one char larger.
