Thread: output for array of pointers is not giving correct values

HI ,

I am giving 1 and 2 inputs for below program.

output giving some other values as i exptectd.

I am expecting 1 and 2 as outputs.

any one can help me ?

Code:

int main()
{
        int *p[2]={};
        int i;

        for (i=0;i<2;i++);
        {
                printf ("enter the nubmer \n");
                p[i]=malloc(sizeof (int ));
                scanf ("%d",p[i]);
                printf ("%d\n",*p[i]);
        }

        for (i=0;i<2;i++)
        {
                printf ("%d\n",*p[i]);
        }
        return 0;
}




output :

enter the nubmer
1
1
Segmentation fault

Did you include <stdlib.h> ?

Try this, instead:

Code:

#include <stdio.h>
#include <stdlib.h>

int main()
{
        int *p[2];
        int i;

        for (i=0;i<2;i++)
        {
                printf ("enter the nubmer \n");
                p[i]=malloc(sizeof (int ));
                scanf ("%d",p[i]);
                //printf ("%d\n",*p[i]);
        }

        for (i=0;i<2;i++)
        {
                printf ("%d\n",*p[i]);
        }
        return 0;
}

Remove the semi-colon from the end of the first line of the for loop code, and fix the int *p line.

Code:

        for (i=0;i<2;i++);  <-- WHOOPS
        {
                printf ("enter the nubmer \n");
                p[i]=malloc(sizeof (int ));
                scanf ("%d",p[i]);
                printf ("%d\n",*p[i]);
        }

        for (i=0;i<2;i++)
        {
                printf ("%d\n",*p[i]);
        }

That semi-colon means the if() is not associated with the following block, so i == 2 when it executes. This allocates and assigns p[2], which could cause a seg fault right there, but evidently it by chance does not.

The seg fault you get happens when the second if() loop starts, because p[0] was never initialized, therefore contains some random address which is dereferenced for a value (but it is out of bounds).

For malloc() you should:

Code:

#include <stdlib.h>

Originally Posted by nkrao123@gmail.

I am compiling on linux mechine.
I am not getting any compilation errors.

You should compile with warnings enabled:

gcc -Wall

Which will give you a clue about having not included stdlib.h for malloc().