Array problem

[Mentallic]

All I want is to input 10 integers into an array and then print them out. The program below is scanning in much more than 10 integers (at least 20) and then the output kind of doesn't make much sense to me. Any ideas what I should fix and anything I can improve on?

#include <stdio.h>

#define MAX 10

int main(int argc, char *argv[]) {
    int array[MAX], i=0;
    
    printf("Enter up to 10 integers:\n");
    
    for (i=0; i<MAX; i++) {
        array[i] = 0;
    }

    i=0;    
    
    while ( (scanf("%d", &array[i]) == 1) && (i<MAX) ) {
        scanf("%d", &array[i]);
        i++;
    }
    
    while (i>=0) {
        printf("%d ", array[i]);
        i--;
    }
    
    printf("\n");

    
    return 0;
}

[laserlight]

Notice that you call scanf twice on each iteration. Fix it to call scanf once per iteration. Also, I suggest that you check i < MAX before scanf.

[Mentallic]

So the way I expressed the while loop, it scans two numbers? Ok thanks I'll see what I can do with your suggestions.

[ssharish2005]

And also you dont have to loop through every element to initialise the array. You could just do this

int array[ MAX ] = { 0 };

ssharish

[Adak]

gosh, but that code looks familiar! Anyway:

Loop 101, here:

    while ( (scanf("%d", &array[i]) == 1) && (i<MAX) ) {
        scanf("%d", &array[i]);  //there's an echo around here!
        i++;
    }

//what is the value of i, right here?
    
    while (i>=0) {
        printf("%d ", array[i]);  //i is one number too high, and out of bounds
        i--;                           //on the first time thru this loop 
    }

To fix the i problem:

    while (i>0) {  //change the test condition, just a bit by removing the =
        printf("%d ", array[--i]);  //decrement i first, before you access arra[i]
        //i--;     <===== don't need this anymore 
    }

Loops that have a comparison test, will run one number past the stop test point. Say you were looping from 0 to 9, in a for loop:

for(i=0;i<10;i++) {
  printf("%d", i);
}
printf("%d", i); //10 will be printed here, not 9

Try that out.