Thread: Program freezing while running a function, please help

I'm not getting a compile error or warning, but the program seems to freeze while running the following function. As input, I send limcounter,
which is the number of actual values in the array (the user inputs values, and can stop input before filling the array, in which case the rest of the elements in the array are 0), and the array with the inputed values.

Does anyone know why it wouldn't be working right, I've stared at this for awhile and I'm stumped

Code:

int factorFind (int limcounter, int ary2 [])
{
  //Declarations
  int indic;     //indicator that factor has been found
  int counter2;     //counter
  int counter3;     //counter
  int factor;     //calculated factor
  int noindic;     //indicator that there is no factor

  //Statements
  indic = 0;
  noindic = 0;
  factor = 1;
  while ( indic == 0 )
  counter3 = 0;
  {
    for ( counter2 = 0; counter2 <= ( limcounter - 1 ); counter2++ )
    {
      if ( factor % ary2[counter2] == 0 )
      {
        ++counter3;
      }
    }
    if ( counter3 == ( limcounter - 1 ) )
    {
      indic = 1;
    }
    else if ( counter3 == limcounter )
    {
      indic = 1;
      noindic = 1;
    }
    else
    {
      ++factor;
    }
  }

  if ( noindic == 1 )
  {
    factor = 0;
  }

  return (factor);
}  //factorFind

Code:

while ( indic == 0 )
  counter3 = 0;

Once you get in that loop, there's no way out of it.

Originally Posted by tabstop

Code:

while ( indic == 0 )
  counter3 = 0;

Once you get in that loop, there's no way out of it.

I don't understand, wouldn't

Code:

if ( counter3 == ( limcounter - 1 ) )
    {
      indic = 1;
    }
    else if ( counter3 == limcounter )
    {
      indic = 1;
      noindic = 1;
    }

cause the program to exit the while loop?

But you have to get out of the loop before you can get to that part, since it is after the while loop. (C goes from top to bottom.)

You've misplaced your braces....

Code:

  while ( indic == 0 )  // this is the entire loop
  counter3 = 0;

// this is not part of the loop

  {
    for ( counter2 = 0; counter2 <= ( limcounter - 1 ); counter2++ )
    {
      if ( factor % ary2[counter2] == 0 )
      {
        ++counter3;
      }
    }
    if ( counter3 == ( limcounter - 1 ) )
    {
      indic = 1;
    }
    else if ( counter3 == limcounter )
    {
      indic = 1;
      noindic = 1;
    }
    else
    {
      ++factor;
    }
  }

  if ( noindic == 1 )
  {
    factor = 0;
  }

..I feel really dumb about that error, but thank you so much for your help