Thread: Don't understand error...

I have a syntax error which after searching around for 15 minutes, am unable to yield results. The error has been commented at lines 70-71. It's a syntax error, so it's missing something, but I don't know what.

I want to make it be able to let you enter a file to upload, specify the ftp directory, and then rename the file to what you desire.

Code:

#include <stdio.h>
#include <string.h>
 
#include <curl/curl.h>
#include <curl/types.h> 
#include <curl/easy.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <errno.h>
#ifdef WIN32
#include <io.h>
#else
#include <unistd.h>
#endif
 
/* NOTE: if you want this example to work on Windows with libcurl as a
   DLL, you MUST also provide a read callback with CURLOPT_READFUNCTION.
   Failing to do so will give you a crash since a DLL may not use the
   variable's memory when passed in to it from an app like this. */ 
static size_t read_callback(void *ptr, size_t size, size_t nmemb, void *stream)
{
  /* in real-world cases, this would probably get this data differently
     as this fread() stuff is exactly what the library already would do
     by default internally */ 
  size_t retcode = fread(ptr, size, nmemb, stream);
 
  printf("*** We read %d bytes from file\n", retcode);
  return retcode;
}
 
int main(void)
{
  char LOCAL_FILE[16];
  char RENAME_FILE_TO[16];
  char UPLOAD_FILE_AS[16];
    
  CURL *curl;
  CURLcode res;
  FILE *hd_src;
  struct stat file_info;
  double speed_upload, total_time;
  curl_off_t fsize;
  
  char *REMOTE_URL = "ftp://example.com/upload_here/";
  char destination[26];
  
  printf("Enter filename to upload (file must be in same working directory ~ enclose filename in double quotes) - ");
  scanf("%s",LOCAL_FILE);
  
  strcpy(UPLOAD_FILE_AS, LOCAL_FILE);
  
  printf("\nEnter the new filename (enclose filename in double quotes) - ");
  scanf("%s",RENAME_FILE_TO);
  
  printf("Enter destination for file (including the new filename ~ leave blank for root)\n");
  printf("%s",REMOTE_URL);
  scanf("%s",destination);
  
  strcat(REMOTE_URL, destination);
 
  struct curl_slist *headerlist=NULL;
  static const char buf_1 [] = "RNFR " UPLOAD_FILE_AS; // Syntax error before UPLOAD_FILE_AS
  static const char buf_2 [] = "RNTO " RENAME_FILE_TO; // Syntax error before RENAME_FILE_TO
 
  /* get the file size of the local file */ 
  if(stat(LOCAL_FILE, &file_info)) {
    printf("Couldnt open '%s': %s\n", LOCAL_FILE, strerror(errno));
    return 1;
  }
  fsize = (curl_off_t)file_info.st_size;
 
  printf("Local file size: %" CURL_FORMAT_CURL_OFF_T " bytes.\n", fsize);
 
  /* get a FILE * of the same file */ 
  hd_src = fopen(LOCAL_FILE, "rb");
 
  /* In windows, this will init the winsock stuff */ 
  curl_global_init(CURL_GLOBAL_ALL);
 
  /* get a curl handle */ 
  curl = curl_easy_init();
  if(curl) {
    /* build a list of commands to pass to libcurl */ 
    headerlist = curl_slist_append(headerlist, buf_1);
    headerlist = curl_slist_append(headerlist, buf_2);
 
    /* we want to use our own read function */ 
    curl_easy_setopt(curl, CURLOPT_READFUNCTION, read_callback);
 
    /* enable uploading */ 
    curl_easy_setopt(curl, CURLOPT_UPLOAD, 1L);
 
    /* specify target */ 
    curl_easy_setopt(curl,CURLOPT_URL, REMOTE_URL);
 
    /* pass in that last of FTP commands to run after the transfer */ 
    curl_easy_setopt(curl, CURLOPT_POSTQUOTE, headerlist);
 
    /* now specify which file to upload */ 
    curl_easy_setopt(curl, CURLOPT_READDATA, hd_src);
    
    /* specify username and password for ftp */
    curl_easy_setopt(curl, CURLOPT_USERNAME, "username");
    curl_easy_setopt(curl, CURLOPT_PASSWORD, "password");
 
    /* Set the size of the file to upload (optional).  If you give a *_LARGE
       option you MUST make sure that the type of the passed-in argument is a
       curl_off_t. If you use CURLOPT_INFILESIZE (without _LARGE) you must
       make sure that to pass in a type 'long' argument. */ 
    curl_easy_setopt(curl, CURLOPT_INFILESIZE_LARGE,
                     (curl_off_t)fsize);
                     
    /* enable verbose for easier tracing */ 
    curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
 
    /* Now run off and do what you've been told! */ 
    res = curl_easy_perform(curl);
    
    /* now extract transfer info */ 
    curl_easy_getinfo(curl, CURLINFO_SPEED_UPLOAD, &speed_upload);
    curl_easy_getinfo(curl, CURLINFO_TOTAL_TIME, &total_time);
 
    printf("Speed: %.3f bytes/sec during %.3f seconds\n", speed_upload, total_time);
 
    /* clean up the FTP commands list */ 
    curl_slist_free_all (headerlist);
 
    /* always cleanup */ 
    curl_easy_cleanup(curl);
  }
  fclose(hd_src); /* close the local file */ 
  curl_global_cleanup();
  getchar();
  return 0;
}

Thanks

I think he's trying to concatenate the strings.
@OP: Look in to strncat

This sort of thing only works when you have two string literals:

Code:

"Hi" " " "there"

in your source ends up being one string. If your RENAME_FILE_TO was a macro that expanded to a string, everybody would be happy. Since it's a real variable, then you have to actually treat it as such.

So all I need to do is strcat UPLOAD_FILE_AS and RENAME_FILE_TO to buf_1 and buf_2?

Originally Posted by binks

So all I need to do is strcat UPLOAD_FILE_AS and RENAME_FILE_TO to buf_1 and buf_2?

Being mindful that you have your dividers ( \ or / ) in the right places...

It may not be as simple as sticking one on the end of another... you may have to strcopy() the first section to a buffer, strcat() the divider then strcat() the last part...

It requires dividers? How so?

I believe Tater is referring to path dividers, as in C:\hey\look\a\file or yahoo.com/another/file.

Oh, I see