incorrect output

Hi guys, I'm fairly new to C as well as programming in general, this is a basic banking program I am working on. It prompts the user to enter name, withdrawal, & deposit amounts then calculates all and gives us the final balance. Well unfortunately its not quite working as it should its basically not calculating the amounts correctly. I have a feeling its due to my loop structure. I just cant figure out what is wrong in there. So any input on this would be helpful.

Code:

#include <stdio.h>

int main (void)

{
    int     deposit_process, withDrl, x;
    float   deposit[50], withDrawal[50];
    float   baLance, Sb, Total;
    char    Name[20];


    printf ("Welcome to the Sears Banking System\n\n");
    printf ("\nPlease enter your first name: ", Name);
    scanf  ("%s", Name);
    fflush (stdin);

    /*----------------------------------*/
    /*Prompt user for balance-----------*/

    do
    {
    printf ("\nHello %s\n\n", Name);
    printf ("%s, please enter your current balance in dollars and cents: ", Name);
    scanf  ("%f", &Sb);
    fflush (stdin);

        if (Sb <= 0)
           printf ("Error: beginning balance must be at least zero, please re-enter.\n");

     }  while (Sb <= 0);

     /*--------------------------------*/
     /*prompt user for # of withdrawals*/

     do
     {
           printf ("\nEnter the number of withdrawals: ");
           scanf  ("%i", &withDrl);
           fflush (stdin);

         if (withDrl <= 0)
           printf ("Error: please re-enter.\n");


     } while (withDrl <= 0);

     /*----------------------------------------*/
     /*Prompt user for # of deposits-------------------*/




     do
     {
         printf ("\nEnter the number of deposits: ");
         scanf ("%i", &deposit_process);
         fflush (stdin);

         if (deposit_process <= 0)
             printf ("Error: Number of deposits must be at least zero, please re-enter\n");


     }while (deposit_process <= 0);

     /*---------------------------------*/
     /*-depostit loop-------------------*/



     for (x = 1; x <= deposit_process; x++){


         do
         {
             printf ("\nEnter the amount of deposit #%i: ", x);
             scanf ("%f",&deposit[x]);
             fflush (stdin);

             if (deposit[x] > 0)

             deposit[x] = deposit[x] + baLance;

             else

             printf("***Deposit amount must be greater than zero. Please re-enter!***\n");

         }while (deposit_process <= 0);



            baLance = Sb + deposit[x];



     }
     //*-------------------------*//
     //*--withdrawal loop---*//



     for (x = 1; x <= withDrl; x++)
     {
         do
         {
             printf("\nEnter the amount of withdrawal #%i: ", x);
             scanf ("%f", &withDrawal[x]);
             fflush(stdin);

             if (withDrawal[x] <= 0)
             printf ("***Error: Number of withdrawals must be greater than 0.***");


             if (withDrawal[x] <= baLance)
                  baLance = baLance - withDrawal[x];

             else
             printf ("***Withdrawal amount exceeds current balance, please re-enter.***\n");





         }while (withDrawal[x] <= 0);

             Total = baLance - withDrawal[x];




     }        /*----------------------------------*/
             /*------closing balance output--------*/


                 printf("\n***The closing balance %s is $%f***\n", Name, Total);

                 if (Total >= 50000)
                 printf("\n***%s it is time to invest some money***", Name);

                 if (Total >= 15000)
                 printf("\n***%s maybe you should consider a CD.***\n", Name);

                 else if (Total >= 1000)
                 printf ("\n***%s keep up the good work!***", Name);

                 else
                 printf ("\n***%s your balance is getting low!***\n", Name);

                /*------------------------------------------------------------*/
               /*---------------Bank printout--------------------------------*/


                 printf ("\n              ***Bank Record***\n");
                 printf ("\nStarting Balance: $                  %f\n", Sb);

                 for (x = 1; x <= deposit[x]; x++ )
                 printf ("\nDeposit #%i:                          %f\n", x, deposit[x]);

                 for (x = 1; x <= withDrawal[x]; x++)
                 printf ("\nWithdrawal #%i:                       %f\n", x, withDrawal[x]);

                 printf ("\nEnding Balance:$                       %f\n", Total);









     return 0;

    }/*----end of program------*/

Originally Posted by Alint808

Hi guys, I'm fairly new to C as well as programming in general, this is a basic banking program I am working on. It prompts the user to enter name, withdrawal, & deposit amounts then calculates all and gives us the final balance. Well unfortunately its not quite working as it should its basically not calculating the amounts correctly. I have a feeling its due to my loop structure. I just cant figure out what is wrong in there. So any input on this would be helpful.

How is it not calculating the amounts correctly?

Additionally, read Why fflush(stdin) is wrong.

Also do you ever expect to have withdrawals or deposits be less that 0? Your error check says no so why are you using %i? These statements should be scanf("%d"...);

Read this.

You might as well make those ints unsigned, and then just check to make sure they are entering numbers less than the size of your array.

Code:

    for (x = 1; x <= withDrl; x++)
     {
         do
         {
             printf("\nEnter the amount of withdrawal #%i: ", x);
             scanf ("%f", &withDrawal[x]);
             fflush(stdin);

             if (withDrawal[x] <= 0)

Arrays start at 0 and go through SIZE-1. So you only get to access array[ 0 ] ... array[ 49 ], not array[ 1 ] ... array[ 50 ].


Quzah.

You do realize that you could improve this profoundly and simplify your code (to about 20 lines) at the same time...

Ask for the initial balance, then...

Enter transaction (+ for deposit) (- for withdrawl) : -32.35

Now you can process any number of deposits and withdrawls in any order and calculate the new balance on the fly, no arrays or batch processing to worry about... and you can do all your banking with simple addition.

Thanks guys, that shed some light on things for me, but what I really to know is what is up with my loop structure the bottom 2 for loops and the middle trap ones, something is wrong with them that is causing the program to add an additional loop after the data has been entered. If you run the program ask for 3 withdrawals and 3 deposits. You enter 1st your three withdrawals then you enter your three deposits on the output side it does not seem to add the start balance & it adds deposit 1, then add deposit 2 with an extra deposit of same amount, then add deposit 3. On the withdrawal side it works a little better but after the 3rd amount it just adds a random float as an extra withdrawal.

Since you have two lines that are adding your deposit to the total:

Code:

deposit[x] = deposit[x] + baLance;

Code:

baLance = Sb + deposit[x];

why are you surprised that your deposits get added twice?

On a more serious note, why do you have a capital letter in the middle of the word withdrawal and balance?


Quzah.

What I was trying to do was have a running balance and a starting balance, but I guess thats not quite working out as planned. Ill tinker with it some more....And as far as the L goes I was trying to liven up the variable .