No result out for this CP

No any result out for tis CP. Any one can help? TQ

Code:

---


#include <stdio.h>

main()
{
    int i,split,n_split;
    float km,n_km;


    printf("Miles\tKilometers\tMiles\tKilometers\n");

    for(i=1;i<=split;i++)
    {
        km=i*1.61;
        split=(1+20)/2;
        n_split=split+i;
        n_km=n_split*1.61;
        printf("%d\t%.2f\t\t%d\t%.2f\n",i,km,n_split,n_km);

    }

    return 0;
}

---

Quote:

---

Originally Posted by leevenchoon

No any result out for tis CP. Any one can help? TQ

Code:

---


#include <stdio.h>

main()
{
    int i,split,n_split;
    float km,n_km;


    printf("Miles\tKilometers\tMiles\tKilometers\n");

    for(i=1;i<=split;i++)
    {
        km=i*1.61;
        split=(1+20)/2;
        n_split=split+i;
        n_km=n_split*1.61;
        printf("%d\t%.2f\t\t%d\t%.2f\n",i,km,n_split,n_km);

    }

    return 0;
}

---

---

What did you expect it to do ?
Shouldn't you give an initial value to split ?

You have not initialised the variable named split before the loop. That means your code exhibits undefined behaviour due to accessing the value of an uninitalised variable, which means ANYTHING is allowed to happen.

In practice, you are probably getting lucky, and split probably contains a value less than 1, so the loop body is never executed. However, with undefined behaviour, more gruesome possibilities are feasible, such as the program being terminated with segmentation violation or it simply reformatting your hard drive.

The solution is to initialise split to something that makes sense before the loop, not within the loop body.

It would be helpful if you posted C in the C section, not the C++ section.

Quote:

---

Originally Posted by Elysia

It would be helpful if you posted C in the C section, not the C++ section.

---

I think your expectations are set just a little too high :wink:

Quote:

---

Originally Posted by AndrewHunter

I think your expectations are set just a little too high :wink:

---

Elysia has given fair guidance, and his expectations are reasonable, so I think you set the bar a little too low.

Quote:

---

Originally Posted by grumpy

Elysia has given fair guidance, and his expectations are reasonable, so I think you set the bar a little too low.

---

I was not suggesting anything to the contrary. It was just meant as a joke; no offense intended.

Any idea how 2 fix it?

You were told how to fix it. Where do you define split(in red)? Is it before or after you use it(in green)?

Quote:

---

Originally Posted by leevenchoon

Code:

---


#include <stdio.h>

main()
{
    int i,split,n_split;
    float km,n_km;


    printf("Miles\tKilometers\tMiles\tKilometers\n");

    for(i=1;i<=split;i++)
    {
        km=i*1.61;
        split=(1+20)/2;
        n_split=split+i;
        n_km=n_split*1.61;
        printf("%d\t%.2f\t\t%d\t%.2f\n",i,km,n_split,n_km);

    }

    return 0;
}

---

---

i test at dev C++ have problems. but my friends test at Code Blocks no problems.

Quote:

---

Originally Posted by grumpy

You have not initialised the variable named split before the loop. That means your code exhibits undefined behaviour due to accessing the value of an uninitalised variable, which means ANYTHING is allowed to happen.

---

Hence undefined. Move your variable definition to before your for loop.

Code:

---

split=(1+20)/2;
for(i=1;i<=split;i++)
    {
        km=i*1.61;
        n_split=split+i;
        n_km=n_split*1.61;
        printf("%d\t%.2f\t\t%d\t%.2f\n",i,km,n_split,n_km);

    }

---

Give some initial value greater than i, that is greater than 1 to split so that loop can be initialized. Change x to any value>i.

Code:

---

int i,split=x,n_split;
    float km,n_km;
    clrscr();


    printf("Miles\tKilometers\tMiles\tKilometers\n");

    for(i=1;i<=split;i++)
    {
        km=i*1.61;
        split=(1+20)/2;
        n_split=split+i;
        n_km=n_split*1.61;
        printf("%d\t%.2f\t\t%d\t%.2f\n",i,km,n_split,n_km);

    }

---

Quote:

---

Originally Posted by PrashantDhamija

Give some initial value greater than i, that is greater than 1 to split so that loop can be initialized. Change x to any value>i.

---

There is no reason to do this. Split does not get calculated in the loop, it is a constant. Simply moving it to before the for loop is all that is required.