I have been using fgets() to read lines of a file I have and store them in a linked list. This has been working very well but after the last line I seem to end up with "x(smiley face)>" in the list. I have checked and this string does indeed result from the last call to fgets before EOF. I have used a hex editor to check the file and at the end of the last line is just the usual 0D 0A. What is going on here?
Right there. See that spot in your code? That's what you did wrong.Originally Posted by Golf7
Quzah.
Hope is the first step on the road to disappointment.
It sounds like you're saving the data from your failed read. Remember that EOF isn't set until reading fails. The last bit of data read must be discarded.
It is too clear and so it is hard to see.
A dunce once searched for fire with a lighted lantern.
Had he known what fire was,
He could have cooked his rice much sooner.
Here is the revevant part of the code:Code:int main(void) { FILE *filein; filein = fopen("input.txt", "r"); struct Node* head = NULL; char* input; while(!feof(filein)) { input = malloc(256); fgets(input, 256, filein); ListAdd(&head, input); } ListPrint(head); ListCleanup(head); fclose(filein); return 0; }
Read the FAQ on why it is bad to use feof() to control a loop (in this way).
Look up a C++ Reference and learn How To Ask Questions The Smart Way
Read: Cprogramming.com FAQ > Why it's bad to use feof() to control a loop
Quzah.Code:char buf[ BUFSIZ ] = {0}; while( fgets( buf, BUFSIZ, filein ) != NULL ) { ... malloc + strcpy + add to list }
Hope is the first step on the road to disappointment.
