Thread: Writing a macro to compare two numbers?

Originally Posted by Bayint Naung

>>Overloaded operators are functions, so there is no problem.
Sure.
The point is readability and it can cause confusion for maintainers.

I don't see how that's an issue here. This is perfectly reasonable code:

Code:

while( !cmp(array1[++run_length],value) );

Originally Posted by King Mir

I don't see how that's an issue here. This is perfectly reasonable code:

Code:

while(!cmp(array1[++run_lengh],value);

Apart from missing closing bracket (which will typically trigger a compiler diagnostic) and misspelling of length, yeah.

However, it is also quite reasonable to - as some coding guidelines do - stipulate that loop condition not have side effects, and code your particular loop as

Code:

while(!cmp(array1[run_length],value))
              ++run_length;

One (often intended) effect of such coding guidelines is that it reduces chances of using macros unsafely.

Of course, the notion of "reasonableness" in code is subjective.