Thread: what is going wrong in sorting program?

Coding:

Code:

//Sorting
#include<stdio.h>
#include<conio.h>
void main()
{
	int arr[5],i,t,count=0;
	for(i=0;i<=4;i++)
	{
	  printf("\n Enter element->");
	  scanf("%d",&arr[i]);
	  printf("%d",arr[i]);
	 }

	for(i=0;i<=4;i++)
	{
	  if(arr[i]<arr[i+1])
	  {
		  t=arr[i];
		  arr[i]=arr[i+1];
		  arr[i+1]=t;
		}
	  count++;
	}
	printf("\n The no of changes are %d",count);
 }

while running this program Surprisingly it is taking 5 inputs and hangs....saying something like "General Protection Exception" and "processor Fault"....
What should i do?is there anything wrong?Please help!!

In your sorting loop, what happens when i = 4 and you are asking for arr[i+1]?

You should change your first for() loop to run on i < 5 ... but the second one needs to run on i < 4...

Originally Posted by mistu4u

Coding:

Code:

//Sorting
#include<stdio.h>
#include<conio.h>
void main()
{
	int arr[5],i,t,count=0;
	for(i=0;i<=4;i++)
	{
	  printf("\n Enter element->");
	  scanf("%d",&arr[i]);
	  printf("%d",arr[i]);
	 }

	for(i=0;i<=4;i++)
	{
	  if(arr[i]<arr[i+1])
	  {
		  t=arr[i];
		  arr[i]=arr[i+1];
		  arr[i+1]=t;
		}
	  count++;
	}
	printf("\n The no of changes are %d",count);
 }

while running this program Surprisingly it is taking 5 inputs and hangs....saying something like "General Protection Exception" and "processor Fault"....
What should i do?is there anything wrong?Please help!!

what do the error messages mean?

They mean you tried to access memory that is not yours to access. Your sorting algorythm was exceeding the bounds of your array.

Read my previous message... the fix is there.

I did not get an error like yours on Dev-C++. Your program was not a SORTING program! Here is a proper sorting program-
Ask if you have queries on this program-

Code:

#include<stdio.h>
#include<conio.h>
int main()
{
	int arr[5],i,j,t,count=0;
	for(i=0;i<=4;i++)
	{
	  printf("Enter elements\t");
	  scanf("%d",&arr[i]);
	 }

	for(i=1;i<=4;i++)
	{
	  for(j=0;j<=3;j++)
	    {
	      if(arr[j]<arr[j+1])
	      {
		   t=arr[j];
		   arr[j]=arr[j+1];
		   arr[j+1]=t;
          }
        }
    }
	for(i=0;i<=4;i++)
	{
	  printf("%d",arr[i]);
	 }

	getch();
	return 0;
 }

If possible, thank me!