copying a mp3 file

help me...i am copying a mp3 file....but when i run the code the copied file is having larger size than the original mp3 file.....here is the code

Code:

#include<stdio.h>
#include<stdlib.h>
int main()
{
    
    FILE *fs,*ft;
    
    unsigned char ch;
    
    fs=fopen("17.mp3","rb");
    if(fs==NULL)
    {
                puts("cannot open source file");
                exit(1);
    }
    ft=fopen("16.mp3","wb");
    if(ft==NULL)
    {
                puts("cannot open target file");
                fclose(fs);
                exit(2);
    }
    while(1)
    {
            ch=fgetc(fs);
            if(ch==EOF)
            break;
            else
            fputc(ch,ft);
    }
    fclose(fs);
    fclose(ft);
    return(0);
}

ch should be an int, if you want to compare it with EOF successfully.

thanks salem.....it is working by taking ch as int
thanks again

Code:

#include<stdio.h>
#include<stdlib.h>
int main()
{
    FILE *fs,*ft;
    unsigned int size;
    unsigned char* buffer;
        
    fs=fopen("17.mp3","rb");
    if(fs==NULL)
    {
                puts("cannot open source file");
                exit(1);
    }
    ft=fopen("16.mp3","wb");
    if(ft==NULL)
    {
                puts("cannot open target file");
                fclose(fs);
                exit(2);
    }
     
    fseek(fs,0,SEEK_END);  // get file size
    size = ftell(fs);
    fseek(fs,0,SEEK_SET);

    buffer = malloc(size);  // allocate buffer space
  
    fread(buffer,size,1,fs);  // copy the file
    fwrite(buffer,size,1,ft);

    free(buffer);
    fclose(fs);
    fclose(ft);
    return(0);
}

Is it worth pointing out the flaws in CommonTater's approach?

Maybe tomorrow, lets see if CommonTater can make a better job.
Or perhaps even spot why the concept is flawed to begin with.

Originally Posted by Salem

Is it worth pointing out the flaws in CommonTater's approach?

Maybe tomorrow, lets see if CommonTater can make a better job.
Or perhaps even spot why the concept is flawed to begin with.

Oh go ahead... you know you want to... Yes I forgot to free the buffer.... what else?

Originally Posted by CommonTater

Oh go ahead... you know you want to... Yes I forgot to free the buffer.... what else?

Think BIG.

Originally Posted by MWAAAHAAA

Think BIG.

What? MP3 files are virtually always under 100megs, most are under 10 ... that should be no problem unless you're on a DOS box...

I've malloced gigabyte size buffers many times with no problems...

O_o

Well, as long as we are posting alternative source...

Soma

Code:

#include <fstream>

int main()
{
    using namespace std;
    ifstream in("17.mp3", ios::in | ios::binary);
    ofstream out("16.mp3", ios::out | ios::binary);
    out << in.rdbuf();
    return(0);
}

Originally Posted by phantomotap

O_o

Well, as long as we are posting alternative source...

Soma

Code:

#include <fstream>

int main()
{
    using namespace std;
    ifstream in("17.mp3", ios::in | ios::binary);
    ofstream out("16.mp3", ios::out | ios::binary);
    out << in.rdbuf();
    return(0);
}

Except that this is the C programming forum

That being the reason that is was a joke... see the smiley?

Soma

Originally Posted by phantomotap

O_o

Well, as long as we are posting alternative source...

Soma

Code:

#include <fstream>

int main()
{
    using namespace std;
    ifstream in("17.mp3", ios::in | ios::binary);
    ofstream out("16.mp3", ios::out | ios::binary);
    out << in.rdbuf();
    return(0);
}

C forum says hello!

I was late...

Originally Posted by phantomotap

That being the reason that is was a joke... see the smiley?

Soma

I can't, where is this???

Originally Posted by phantomotap

That being the reason that is was a joke... see the smiley?

Soma

Nah, I think you couldn't find the delete button, so you're trying to save face by putting in an edit.

Nah, I think you couldn't find the delete button, so you're trying to save face by putting in an edit.

Along that path lies boredom.

Soma