problem in printing

[lizie]

hello
the following part of the programme returns <null> and i cant see the mistake..
the file1.txt contains a list of names and last names so it was supposed to print one name at a time.

FILE *source;
char line[100];

typedef char* type;
type x;

source = fopen("file1.txt","a+");
if (source == NULL){
            printf("ERROR!!!file not found!");       }
while(!feof(source)){
            x = fgets(line,100,source);
            printf("%s\n",x);
        }

[quzah]

Wow, where to even begin on this one? Oh I know, how about at a pet peeve of mine!

typedef char* type;

I hate people that do this.

source = fopen("file1.txt","a+");source = fopen("file1.txt","a+");

You are opening in append mode (well a+ technically), and as such, the file pointer is at the end of the file:

``a+'' Open for reading and writing. The file is created if it does not
exist. The stream is positioned at the end of the file. Subse-
quent writes to the file will always end up at the then current
end of file, irrespective of any intervening fseek(3) or similar.

while(!feof(source)){

There are very few times when you should use feof for loop control. This isn't one of them. Read the FAQ on it.


Quzah.