Thread: Having problem with a program for Bingo

Currently having problems with random number generator for the bingo program. It only gets one random number and it doesn't change each time it goes through the while loop. The if function doesn't follow the instruction of changing the cell of the number to asterisk when the random number and cell values match.

Code:

// Bingo main.c

#include <stdio.h>
#include "globals.h"
#include "card.h"
#include "randomnumber.h"
#include "unusednumbers.h"
#include <conio.h>
char finitial, linitial, Player1;

int main()
{
    int iseed;
    printf(" Welcome to the game of Bingo\n");
    
    printf("Enter your initials\n");
    scanf(" %c %c", &finitial, &linitial);
    initRandom();
    newCard();
    Displaycard();
    int count;
    count = 0;
    while (i < 25)
    {
          srand (time (NULL) );
    iseed = rand() % 75 + 1;
    
    printf( "Calling first number :%d\n", iseed);
    if(iseed == MARKED_VAL)
    {
             printf("  **  ");
             i = i +1;
             }
    if(iseed != MARKED_VAL)
    {
             printf(" The number %d is not on the board\n", iseed);
             i = i +1;
             
}

}
    printf(" Thank you for joining us %c%c\n", finitial, linitial);
    system("Pause");
}

Code:

//card.c
#include<stdio.h>
#define MARKED_VAL 0
int bingoCard[NUMROWS][NUMCOLS];

void newCard(void)
{
     int nchoice = MULT;
     int row, col;
     int min, max;
     
     for (col = 0; col < NUMCOLS; col++)
     {
         min = (col * nchoice) + 1;
         max = (col + 1) * nchoice;
         
         for (row = 0; row < NUMROWS; row++)
         {
             bingoCard[row][col] = myRandom(min, max);
         }
     }
     bingoCard[(row / 2)] [(col / 2)] = MARKED_VAL;
}
                
void printCell(int cellValue)
{
     printf("|");
     if (cellValue == MARKED_VAL)
     {
                   printf("  **  ");
     }
     else
     {
         printf("  %2d  ", cellValue);
     }              
}

void Displaycard(void)
{
  int i, j;
  printf("\n Bingo Card for Player 1\n\n");
  printf("+------+------+------+------+------+\n");
  printf("|  B   |  I   |  N   |  G   |  O   |\n");
  printf("+------+------+------+------+------+\n");
  
  for (i = 0; i < NUMROWS; i++)
  {
      for (j = 0; j < NUMCOLS; j++)
      {
          printCell (bingoCard[i][j]);
          }
          printf("|\n+------+------+------+-------+------+\n");
}
}

Code:

//randomnumbers.c #include <stdlib.h>
#include <time.h>

void initRandom(void)
{
     unsigned int iseed = (unsigned int) time(NULL);
     srand (iseed);
}
     
int myRandom(int low, int high)
{
    return (low + rand() % (high - low + 1));
}

You should move your myrandom function into the main C source page and dispense with the initRandom all as it doesn't gain you anything in terms of randomness... Try it like this...

Code:

 srand (time (NULL) );  // only call this once per program run, right at the beginning.


 int MyRandom(int low, int high)
   { return (rand % (high - low)) + low;

With that code placed in the main I get errors of invalid operands to binary %

Originally Posted by Magmadragoon

With that code placed in the main I get errors of invalid operands to binary %

OOPS... my bad... should have been...

Code:

int MyRandom(int low, int high)
   { return (rand() % (high - low)) + low;}

...that's what I get for not proofreading more carefully and that's what you get for doing scoop and poop...

With putting the random number generator I had linking errors due to code from card.c calling myRandom. So I just kept the way I had before. Still trying to find a way so I can call a random number, mark it on the board, then call the next numbers.

Code:

// Bingo main.c

#include <stdio.h>
#include "globals.h"
#include "card.h"
#include "randomnumber.h"
#include "unusednumbers.h"
#include "blockChars.h"
#include <conio.h>
#include <stdlib.h>
#include <time.h>
#define TRUE 1
#define FALSE 0
char finitial, linitial, Player1;

int main()
{
    initRandom();
/*    srand (time (NULL) );


 int MyRandom(int low, int high)
   { 
                  return (rand() % (high - low)) + low;
   } */
    int iseed, j, randomn, low, high;
    printf(" Welcome to the game of Bingo\n");
    
    printf("Enter your initials\n");
    scanf(" %c %c", &finitial, &linitial);
    
    newCard();
    Displaycard();
    randomn = myRandom(low, high);
    printf(" Calling first number :%d\n", randomn);
   // printCell (bingoCard[i][j]);
   
       /*while (i < 25)
    {
          srand (time (NULL) );
    iseed = rand() % 75 + 1;
    
    printf( "Calling first number :%d\n", iseed);
    if(bingoCard[i][j] == iseed)
    {
             printf("  **  ");
             i = i +1;
             }
    if(bingoCard[i][j] != iseed)
    {
             printf(" The number %d is not on the board\n", iseed);
             i = i +1;
    */

   

    printf(" Thank you for joining us %c%c\n", finitial, linitial);
    system("Pause");
}

Code:

//card.c
#include<stdio.h>
#define MARKED_VAL 0
int bingoCard[NUMROWS][NUMCOLS];

void newCard(void)
{
     int nchoice = MULT;
     int row, col;
     int min, max;
     
     for (col = 0; col < NUMCOLS; col++)
     {
         min = (col * nchoice) + 1;
         max = (col + 1) * nchoice;
         
         for (row = 0; row < NUMROWS; row++)
         {
             bingoCard[row][col] = myRandom(min, max);
         }
     }
     bingoCard[(row / 2)] [(col / 2)] = MARKED_VAL;
}
                
void printCell(int cellValue)
{
     printf("|");
     if (cellValue == MARKED_VAL)
     {
                   printf("  **  ");
     }
     else
     {
         printf("  %2d  ", cellValue);
     }              
}

void Displaycard(void)
{
  int i, j;
  printf("\n Bingo Card for Player 1\n\n");
  printf("+------+------+------+------+------+\n");
  printf("|  B   |  I   |  N   |  G   |  O   |\n");
  printf("+------+------+------+------+------+\n");
  
  for (i = 0; i < NUMROWS; i++)
  {
      for (j = 0; j < NUMCOLS; j++)
      {
          printCell (bingoCard[i][j]);
          }
          printf("|\n+------+------+------+-------+------+\n");
}
}

int updateCell(void)
{
}

int checkforWin()
{
}

int checkRows()
{
    int i, j;
    for ( i = 0; i < 5; i++)
	  for( j = 0; j < 5; j++)
		if (bingoCard[i][0] == bingoCard[i][j]) 
		  return 1;
}

int checkColums()
{
    int i, j;
    for( i = 0; i < 5; i++)
	for ( j = 0; j < 5; j++)
	   if (bingoCard[0][j] == bingoCard[i][j]) 
		 return 1;
}

int checkDiagnols()
{
     int i;
     for( i = 0; i < 5; i++)
	
  if (bingoCard[0][0] == bingoCard[i][i]) 
	   return 1;
}

I think the problem is with randomn = myRandom(low, high);

Originally Posted by Magmadragoon

I think the problem is with randomn = myRandom(low, high);

Well... what error messages is your compiler giving you?

I have no errors just when I run the program the random number is over a thousand when I want it to be between 1 and 75

Originally Posted by Magmadragoon

I have no errors just when I run the program the random number is over a thousand when I want it to be between 1 and 75

Yeah you do have errors, and I'm betting lots of them... You've put the myRandom function I wrote inside your main function... You can't do that in C.

This isn't hard...

Code:

#include <stdio.h>
#include <time.h>

int MyRandom(int low, int high)
  { return (rand() % (high - low)) + Low; }


int main ( void )
  { int x; // random number
    
    srand(time(NULL));

    // lots of other code

    x = MyRandom(10,20);

    // diagnostic (Random should be between 10 and 20)
    printf("Random = %d\n",x);

    // and done
    return 0; }

Go ahead, create a new project and test it...

I see what I was doing I was initially putting the function MyRandom in the main function causing the error. Then for assigning Randomn I was calling low, high instead of setting the bounds for the program.

When the random number value is the same as the one already on the Bingo card the number on the card doesn't change.

Originally Posted by Magmadragoon

I see what I was doing I was initially putting the function MyRandom in the main function causing the error. Then for assigning Randomn I was calling low, high instead of setting the bounds for the program.

Well, you can call it with variables named high and low or x and y or top and bottom or whatever you like... provided they're set to reasonable values before you make the call.

Originally Posted by Magmadragoon

When the random number value is the same as the one already on the Bingo card the number on the card doesn't change.

Ok... first thing... clean up your code. Now that you get how the random numbers work in C, you need to clean out all the other stuff you tried before you go much further.

Moreover... this is not a big project... I don't see any reason to split it up into multiple files, moreover there is no logical separation. It's not like you're developing a Network module, a Messaging module and a GUI module here... it's all one thing. (FWIW, I have source pages here that are thousands of lines long.)

Make your life easier and order your functions on the main .C file above main() so that nothing is called before it's seen, work out the logic problems... minimize the code as much as possible... and you're done.

The instructor had us do the assignment with the multiple files. Just still can't figure out how to mark each called number with an asterisk on the card.