Thread: Help: Segmentation fault (core dump) error

Hi, I am pretty new to C and having some trouble that seems pretty challenging to my limited knowledge and experience. Everytime I tried to execute any program containing any sort of randomization code, I get back this error message:"Segmentation fault (core dump). Here's an exemple of one of my codes

Code:

//This program demontrates the use of the randomization concept.

#include<stdio.h>

main() {

 int iRandomNum = 0;
 srand(time());
 iRandomNum = (rand() %4) + 1;

 printf("\nFortune Cookie - Chapter 3\n");

switch (iRandomNum) {
 
 case 1:
 printf("\nYou will meet a new friend today.\n");
 break;

 case 2:
 printf("\nYou will enjoy a long and happy life.\n");
 break;

 case 3:
 printf("\nOpportunity knocks softly, can you hear it?\n");
 break;

 case 4:
 printf("\nYou'll be financially rewarded for your good deeds.\n");
 break;
 }
}

I have a hunch that it might be related to my system version (windows xp SP 3 / GCC 4.3.4 ) but I can't quite confirm. Please Help.

Crank up them warnings:

Code:

$ gcc -Wall foo.c
foo.c:5: warning: return type defaults to ‘int’
foo.c: In function ‘main’:
foo.c:8: warning: implicit declaration of function ‘srand’
foo.c:8: warning: implicit declaration of function ‘time’
foo.c:9: warning: implicit declaration of function ‘rand’
foo.c:31: warning: control reaches end of non-void function

You need to include time.h and stdlib.h for the correct prototypes for srand() and time(). Then, your compiler should warn you:

Code:

$ gcc -Wall foo.c
foo.c:7: warning: return type defaults to ‘int’
foo.c: In function ‘main’:
foo.c:10: error: too few arguments to function ‘time’

You need to pass in a pointer to a struct tm into time, or better yet, pass NULL for the current time. Also, it's int main(void) and return an integer at the end, usually zero.

EDIT: The reason for the seg fault was the lack of parameter to time(). The time function was grabbing whatever garbage was on the stack, which was mostly likely not a NULL address, thus trying to dereference invalid memory.

First you need to include the include files required by srand() (stdlib.h) and time() (time.h). Also your call to time() does not have the proper number of arguments.

You need to check your compiler settings and insure that warnings are be emitted. If you are using gcc at the command line then you should add at least -Wall -Wextra. If you are using an IDE then check the IDE's settings to turn warnings on.

Jim