segmentation violation

[gooseantlers]

I just can't figure out where this error is coming from. I get a segment violation each time. Does anyone have any ideas. This is my first attempt at working with files, so any help would be nice. Thank you

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

void filename_accept(char fileName[]);
int main()
{
    FILE *myfile;
	char fileName[40];
	char fileData[1000];
	int c;

	filename_accept(fileName);

    myfile = fopen(fileName,"r");

		while((c = fgetc(myfile)) != EOF)
			{
				int i=0;
				fileData[i++] = c;
			}

    fclose(myfile);
	free(fileData);

    return 0;
}


void filename_accept(char fileName[])    /*Reads in file name*/
{

	printf("\nEnter file you would like to open:\n");
	gets(fileName);

}

[jimblumberg]

First never use gets, use fgets(). See this link.

Second you are using free on a pointer that you did not malloc. The fileData variable was statically allocated fileData[1000].

Jim

[CommonTater]

char filedata[1000];


		while((c = fgetc(myfile)) != EOF)
			{
				int i=0;    
				fileData[i++] = c;
			}

Filedata should be initialized to 0 ...

char filedata[1000] = {0};

... should work as long as you don't read more than 1000 characters.
Also the int i = 0; should be executed only once above your while loop... unless you want to repeatedly write to filedata[0];

[gooseantlers]

I'm still getting the segmentation error even with the suggested changes from CommonTater.

char filedata[1000];


		while((c = fgetc(myfile)) != EOF)
			{
				int i=0;    
				fileData[i++] = c;
			}

Filedata should be initialized to 0 ...

char filedata[1000] = {0};

... should work as long as you don't read more than 1000 characters.
Also the int i = 0; should be executed only once above your while loop... unless you want to repeatedly write to filedata[0];

[laserlight]

What is your current code?

[Salem]

> free(fileData);
If you didn't call malloc, then don't call free.

freeing something you didn't malloc is a bad thing.