n00b question regarding loop termination

[twazzler]

Hi,

I'm a beginner, please be gentle!

I have created a very simple program which reads in the dimensions of a rectangle then calculates area and volume.

The loop will terminate if a non-numerical integer is entered - is there a way of making it terminate if an integer which is equal to or less than 0 is entered? Ideally I'd like to make it so the loop will terminate if 0 or a negative number is entered at any of the three scanf() stages (enter length, enter width, enter height).

Here's my code:

#include <stdio.h>
int main(void)
{
    int length, width, height;
    
    printf("Enter the length of the rectangle: ");
    while (scanf("%d", &length) == 1)
    {
       printf("Length = %d:\n", length);
       printf("Enter the width: ");
       if (scanf("%d", &width) !=1)
          break;
       printf("Enter the height: ");
       if (scanf("%d", &height) !=1)
          break;    
       printf("The rectangle's area is %d and its volume is %d.\n", width * height, (length * width) * height);
       printf("Enter the length of the rectangle: ");
    }
    
    printf("Invalid - BYE.\n");

    getchar();
    getchar();
    getchar();
    return 0;
    
}

Any advice/guidance gratefully received

Cheers,

Twazzler

[Bayint Naung]

if( width <= 0 ) {

break;
}

Duh~ Did you even read your text book?
Edit: added break;

[twazzler]

Did I even read my text book?!

Yes I did, until the words became a painful blur...it wasn't very helpful, hence my posting the question here.

Very kind of you to reply, but where in the code would I add that without disrupting the existing entries?

[nonoob]

for (;;) { /* forever */
    printf("Enter the length of the rectangle: ");
    scanf("%d", &length);
    if (length <= 0)
        break;

    printf("Enter the width: ");
    scanf("%d", &width);
    if (width <= 0)
        break;

    printf("Enter the height: ");
    scanf("%d", &height);
    if (height <= 0)
        break;

    printf("The rectangle's area is %d and its volume is %d.\n", width * height, (length * width) * height);
    }
...
bye bye stuff

[Abhas]

Are you mad nonoob? You have written an infinite loop unless any non-positive value is used.
Use condition to stop the scanf function only after 1 valid input has been taken for each of the required values.
Twazzler you should make the program better so as to show an error message and ask for the value again.

[nonoob]

Are you mad nonoob? You have written an infinite loop unless any non-positive value is used.

It's what was asked for.

[Abhas]

oh sorry i misunderstood the question.

[twazzler]

Thank you - so was there no way of doing what I wanted to do with a while loop? It would have to be for?

[nonoob]

Since you want to terminate when ANY of the three entered values is <=0, then any loop would look similar. Even a while.
I suppose you could do while (1) { ... } which means while always true.

[twazzler]

Thanks again.

I have also written some code which replaces the vowels of an inputted sentence with 'Z'. If I wanted to remove the whitespaces from the outputted sentence, what would I put below if (ch == ' ') to remove it?
Here's what I have so far:

#include <stdio.h>
    int main(void)
    {
        char ch;
        
        while ((ch = getchar()) != '.')
        {
              if (ch == 'a' || ch == 'e' || ch == 'i' || ch == 'o' || ch == 'u') 
              putchar('Z');
              else
                  putchar(ch);
              
        }
        putchar(ch);
        
        getchar();
        return 0;
        
        }

[nonoob]

if (ch == 'a' || ch == 'e' || ch == 'i' || ch == 'o' || ch == 'u') 
    putchar('Z');
else if (ch == ' ')
    /* do nothing */ ; <-- yes you need this semicolon
else
    putchar(ch);

[twazzler]

nonoob, you are a gentleman and a scholar