Hello everybody!
I need to create a function from
And I wrote thisCode:#include <stdio.h> main() { int i; char s[10]; gets(s); for(i=0;s[i]!='\0';i++) { if (s[i]==' ') s[i]='_'; } printf("%s",s); getch(); return 0; }
As a result, It's not right.Code:#include <stdio.h> int zm(char *s) { int i; gets(s); for(i=0;s[i]!='\0';i++) { if (s[i]==' ') s[i]='_'; return *s; } } main() { printf("%s",s); getch(); return 0; }
Could anybody write how to do it correctly
1) Never use gets(). Read the FAQ as to why that is.
2) main() should be int main(void)
3) you are never calling your function in main.
1. Get rid of gets(). Never ever ever use it again. Replace it with fgets() and use that instead.
2. Get rid of void main and replace it with int main(void) and return 0 at the end of the function.
3. Get rid of conio.h and other antiquated DOS crap headers.
4. Don't cast the return value of malloc, even if you always always always make sure that stdlib.h is included.
Well, it might help if you actually called the function...Originally Posted by ScariuM
What claudiu said, plus, you need to define s. Your code shouldn't even compile as it stands.
Hm... Lots to say here...
It looks like you're trying to read in a string and change all the spaces to underscores. First of all, gets() is a dangerous function. Everyone around here will recommend fgets(). Strongly. But it looks like you want basically to:
so you'll have to define your function as:Code:int main(){ //get string fgets(s, 10, stdin); //nevermind the magic numbers //change spaces to underscores somefunc(s); //print string printf("%s",s); return(0); }
Code:void somefunc(char *s){ //this is where you do your string transformation. }
Last edited by FrankTheKneeMan; 04-06-2011 at 11:08 AM. Reason: end tag
Now, compiler write: "Declaration syntax error in function main" and show to gets(s)Code:#include <stdio.h> int zm(char *s) { int i; for(i=0;s[i]!='\0';i++) { if (s[i]==' ') s[i]='_'; return *s; } } main(void) { char s[10] gets(s); zm(s); printf("%s",s); return 0; }
Your indentation is all wacky. Proper indentation makes things much easier to see, things like your return *s, which should be outside the for loop. Also, look one line above the gets call. What are you missing there?
EDIT: And claudiu already told you, it's int main(void). You need that int in front of main.
i missed ";"
Thanks a lot to everybody!!!!!!!
Last edited by ScariuM; 04-06-2011 at 11:50 AM.
You missed more than that:
- zm is not a descriptive name.
- Your poor indentation hides a logic error with your loop, assuming that you are trying to replace every space with an underscore.
- Why is the return type of zm int? Is the function supposed to return the number of characters replaced?
- You should explicitly state the return type of main as int.
- You missed the warnings not to use gets.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
