Problem with array.

[Fink]

Hi. I'm having problems with an C exercise. So the exercise says: "Make a function with one variable (int k) which returns an array of the size of k where every box (sorry for my bad english) of the array is 1." So this is what I did.

#include <stdio.h>
#include <stdlib.h>

int pinakas(int k){
    int i,c[i];
    for(i=0;i<k;i++){
       c[i]=1;
       printf("%d",c[i]);
       }        
}

main(){
  
  int a;
  printf("Give integer: ");
  scanf("%d",&a);
  pinakas(a);
  system("pause");
}

The program works, as long as I put 3 as an integer, if I put a number which is greater than 3 the program crashes. I could do the problem without an array (where instead of c[i] I would put c) and it works fine. So what am I doing wrong here? Thanks.

[anduril462]

int pinakas(int k){
    int i,c[i];

i is used unintialized here, thus c is of some arbitrary size (did you mean to use k?). Your compiler should warn you about that, so crank up the warnings or get a new one.

main(){

It's int main(void) and return an integer at the end (usually 0). Read why it matters here.

EDIT: You also don't return anything from pinakas. Either define it with void return type or return a sensible integer.

[Fink]

I didn't see the c[i] mistake I did. Thanks for pointing out the main() thing, but I can't remember my teacher telling us that we have to write int main(void) and it should return 0. The way I first wrote it is the way we've learned it...

[anduril462]

Well, your teacher is teaching you crap. Read the link I posted regarding the problems with what you're doing (click the red text in my previous post). Perhaps even explain to your teacher you heard that his/her way is wrong and you want to know whether it's really wrong and why you're being taught that way.