Thread: Counting Occurances of a Character

Hi,

I need help trying to do the following:
Basically, I am trying to count the occurrences of each character in a text file. I'm reading in line by line, and then in each line, analyzing character by character.

I'm maintaining an array of the counts.

The conversion of the character to ascii and then ascii to its proper index is working, but when I try to print out the contents of the array, I'm getting ridiculous numbers. Here's my code:

Code:

int autoGuess() {

int r, x, size, asciiEquiv;  
int charCount[26];


for (r = 0; r < lineCount ; r ++) /* Outer Loop Reads Line By Line */

{

	for (size = 0; size < sizeof(stringArray[r]); size++) {      /*Inner Loop Reads character by character */


		if (isalpha((stringArray[r][size])))

		{

			asciiEquiv = (int)stringArray[r][size];
		/*	printf("%d " , asciiEquiv); It is converting the characters to their respective ASCII codes properly */
			place = asciiEquiv - 97; 
		/*	printf("%d ", place);  Converting to Index Properly */
		    charCount[place]++;
			printf("%d " , charCount[place]);  // Something happens here
			

	    }

         
	
	}


	

}


for (x = 0; x < 26 ; x ++) {

//printf("%d ", charCount[x]); 
	getchar();


}


}

Thanks!

Alright, that works !

Elementary mistake..

Thanks

Code:

for (size = 0; size < sizeof(stringArray[r]); size++) {      /*Inner Loop Reads character by character */

Are you sure that you want to use sizeof() here?

Why would that be an issue?

This is highly dangerous:

Code:

place = asciiEquiv - 97; 
		/*	printf("%d ", place);  Converting to Index Properly */
		    charCount[place]++;

You are assuming that all characters are guaranteed to be 'a' to 'z'. That is, lowercase only... not spaces, no special punctuation.
sizeof(), as was pointed out, will make it loop to the end of each row regardless of whether there is valid data. The rows may contain uninitialized (garbage), or zeroes, which would put your index outside the valid range.