Beginner, cant get my program to run :-(

question im asked to do :
write a program that acts as a simple printing calculator i should accept in the form of number then operator.

The following operators should be reconised '+', '-', '/', '*' 'S' 's' 'E' 'e'
The S operator tells the program to set the accumulator to the typed in number.
The E operator tell the program to excute to the end
Make certain the program checks for division by zero.
My effort so far;

Code:

#include <stdio.h>

int main (void)

{
	double value1
	float accumulator = 0.0f;
	char operator;

	printf ("\t\tCalulator\n"); 
	printf ("\t\t---------\n");

	printf("Type in your test\n");
	scanf("%d, %c", value1, operator);



	if (value1 == 0)
		printf("Divsion by zero is not allowed");

	switch (operator)
	{
	     case 'S':
	     accumulator = value1;
		printf("%2.f\n", value1);
	     break;

	     case 's';
	     accumulator = value1:
		printf("%2.f\n", value1);
	     break;

	     case '+':
	     accumulator+= value1;
		printf("%2.f\n", value1;
	     break;

	     case '-':
	     accumulator= accumulator - value1;
		printf("%2.f\n", value1);
	     break;

	     case '/':
	     accumulator= accumulator / value1;
		printf("%2.f\n", value1);
	     break;

	     case '*':
	     accumulator= accumulator - value1;
		printf("%2.f\n", value1);
		
	     break;

	     case 'E':
	  	printf("End of Tests");
	     break;

	     case 'e':
		printf("End of Tests");
	     break;
	 
	     default:
		printf("UNKNOWN OPERATOR\n");
	     break;

}

	return 0;

}

any help or tips would be great

What problems are you having?


Quzah.

Please be specific in the future. What's the actual problem? Does it compile? Does it crash when you try to run it? Does it give incorrect output? What output does it give and what do you expect. Cut and paste the compiler errors you don't understand.

I couldn't get it to compile as you posted it. You're missing a semicolon in your variable declarations and a closing parenthesis in the printf in your case '+'. Also, your case 's' has some mixups between colon : and semicolon ;. The colon is for the case label, the semicolon terminates a statement. You need to read up on scanf. It takes the address of the variable you want to store in there, so you need:

Code:

    scanf("%f, %c", &value1, &operator);

%d is for integers, %lf is for floats.

Originally Posted by anduril462

%lf is for floats.

f is for float, lf is for double.


Quzah.

My guess is that it doesn't even compile:

Code:

printf("%2.f\n", value1;

Originally Posted by quzah

f is for float, lf is for double.


Quzah.

Yes, thanks for catching that. OP wants %lf since value1 is a double.