Fgets and Fprintf Errors?

[Charak]

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>

typedef struct
{
        char studentName[50];
        int studentId;
}       database;

int main(int argc, char *argv[])
{
    database school;
    FILE *file_ptr;
    char text[50];
    int begin,temp;
    
    while(1)
    {
    printf("Input Data? (Yes = 1) : ");
    scanf("%d",&begin);
    
              if(begin != 1)          
              {
              break;
              }
    else
    {
            printf("\nEnter Student Name: ");
            fgets(school.studentName, 50 , stdin);
            
            printf("\nEnter Student ID: ");
            scanf("%d", &school.studentId);
                  
            printf("\nAdd to school.csv ?(y/n) : ");
            getchar();
            scanf("%c", &temp);
                
                        if(temp == 'y' || temp == 'Y')
                        {
                                file_ptr = fopen("school.csv" , "a");
                                printf("\nFile school.csv opened\n");
                                fprintf(file_ptr, "%s, %d,\n", school.studentName, school.studentId);
                                fclose(file_ptr);
                                printf("File Saved.\n\n");
                        }
                               
                      
                else
                {
                printf("\nFile not Saved.\n\n");   
                }

}   
}
  system("PAUSE");	
  return 0;
}

The program is skipping over the student name input, so Im assuming the fget is incorrect, how do i fix that?

            printf("\nEnter Student Name: ");
            fgets(school.studentName, 50 , stdin);

Also, when I get to the prompt to save, I enter y and it says file not saved. Is it because my fprintf is wrong, if so how do i fix it?

printf("\nAdd to school.csv ?(y/n) : ");
            getchar();
            scanf("%c", &temp);
                
                        if(temp == 'y' || temp == 'Y')
                        {
                                file_ptr = fopen("school.csv" , "a");
                                printf("\nFile school.csv opened\n");
                                fprintf(file_ptr, "%s, %d,\n", school.studentName, school.studentId);
                                fclose(file_ptr);
                                printf("File Saved.\n\n");
                        }

other than that, it complies with no bugs atm =/

[jimblumberg]

The program is skipping over the student name input, so Im assuming the fget is incorrect, how do i fix that?

Your problem is probably the new line character in the input buffer from the previous scanf(). You can try to put a getchar() after the first scanf().

Jim

[Charak]

Your problem is probably the new line character in the input buffer from the previous scanf(). You can try to put a getchar() after the first scanf().

Jim

That worked thank you. Now I need to fix my fprintf so that'll save the file

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ctype.h>

typedef struct
{
        char studentName[50];
        int studentId;
}       database;

int main(int argc, char *argv[])
{
    database school;
    FILE *fp;
    char text[50];
    int begin,temp;
    
    while(1)
    {
    printf("Input Data? (Yes = 1) : ");
    scanf("%d",&begin);
    getchar();
    
              if(begin != 1)          
              {
              break;
              }
    else
    {
            printf("\nEnter Student Name: ");
            fgets(school.studentName, 50 , stdin);
            
            printf("\nEnter Student ID: ");
            scanf("%d", &school.studentId);
                  
            printf("\nAdd to school.csv ?(y/n) : ");
            scanf("%c", &temp);
            getchar();
                
                        if(temp == 'y' || temp == 'Y')
                        {
                                FILE *fp = fopen("school.csv" , "a");
                                
                                if (fp != NULL)
                                {
                                printf("\nFile school.csv opened\n");
                                }

                                fprintf(fp, "%s, %d,\n", school.studentName, school.studentId);
                                fclose(fp);
                                printf("File Saved.\n\n");
                        }
                               
                      
                else
                {
                printf("\nFile not Saved.\n\n");   
                }

}   
}
  system("PAUSE");	
  return 0;
}

[jimblumberg]

The problem with your file writing is probably in this logic.

                  if(temp == 'y' || temp == 'Y')

First temp is defined as an int and you are using here as a character.

Second, where do you ever assign a value to this variable?

Jim

[Charak]

The problem with your file writing is probably in this logic.

                  if(temp == 'y' || temp == 'Y')

First temp is defined as an int and you are using here as a character.

Second, where do you ever assign a value to this variable?

Jim

I changed int temp to char temp;


I dont understand the 2nd question. scanf("%c", &temp); ?

[jimblumberg]

I dont understand the 2nd question. scanf("%c", &temp); ?

Sorry I missed that in your code.

Jim

[Charak]

it will print if I remove the else and change it to if(temp = 'y') but thats not what I want

[jimblumberg]

          scanf("%d", &school.studentId);
                  
            printf("\nAdd to school.csv ?(y/n) : ");
            scanf("%c", &temp);

In the above code the first scanf is leaving the newline character in the buffer, you need to remove the newline character with getchar().

Jim

[hk_mp5kpdw]

int begin,temp;

...

printf("\nEnter Student ID: ");
scanf("%d", &school.studentId);
                  
printf("\nAdd to school.csv ?(y/n) : ");
scanf("%c", &temp);

#1. temp is an int so you should either change the format specifier in the scanf call to %d or make temp a char.

#2. If temp is made a char and you are using a %c format specifier, then this scanf call will need to have the input buffer cleared as you did before prior to calling it. This can be done as suggested by jimblumberg with another getchar call, or by altering the scanf call to have a space in front of the %c format specifier.

printf("\nAdd to school.csv ?(y/n) : ");
scanf(" %c", &temp); /* Notice space in front of %c here! */

The space lets scanf know that it should ignore leading whitespace before processing user input.

[Charak]

thank you, its finally fixed