Thread: this code won't work

good morning ;
this programme is created to find x^y
but it show every time an random number !!!
could you help me please
and thank you so much ....

Code:

#include <stdio.h>
int nbpos (int x)
{
    int c,cpt ;
    do
    {
        x=x/10;
        c++;
    }
    while (x!=0);

    return c;
}


int puiss (int x , int y)
{
    int i=1,s=1;
printf ("\n--- x == %d --- s == %d---- y == %d\n",x,s,y);    
/*
for (i=1;i<y;i++)
    {
        s=s+1;
        
    }
*/
return s;
}

main()
{
int x=10,y,e;

    scanf("%d",&y);
    printf (" %d  ********** \n",nbpos(y));


e=nbpos(y);
e=puiss (x,e);
printf("////// %d \n",e);
}

Originally Posted by med linux

but it show every time an random number !!!

Code:

#include <stdio.h>
int nbpos (int x)
{
    int c,cpt ;
    do
    {
        x=x/10;
        c++;
    }
    while (x!=0);

    return c;
}

Notice that c is not initialized to any particular value, so it's value is random.

Originally Posted by med linux

good morning ;
this programme is created to find x^y
but it show every time an random number !!!
could you help me please
and thank you so much ....

Please don't use giant colored text... It makes you look like an idiot.

Code:

#include <stdio.h>
int nbpos (int x)
{
    int c,cpt ;
    do
    {
        x=x/10;
        c++;
    }
    while (x!=0);

    return c;
}

your integer c is used without initialization... so you're doing math on garbage.
cpt is never used.

Originally Posted by med linux

the problem is in the color or in the color and the size ?

Both...

When I see giant red text the first thing that goes through my mind is "10 year old at the keyboard".

In fact, it almost certainly has the opposite of the effect you intended...
When I see crap like that I generally just go read something else.

Fixed colour and size