Thread: Segmentation Fault Help

Code:

#include<stdio.h>
#include<stdlib.h>

int main()

{

FILE *ofp;

ofp = fopen("Cards.dat", "r");

if (ofp == NULL)
{
 printf("Unable to open Cards.dat");
}

int numbers[10][2];
int r, c, n;

for (r = 0; r < 100; ++r)
   {
   for(c = 0; c < 2; ++c)
      {
      fscanf(ofp, "%d", &n);
      numbers[r][c] = n;
      }
   }

printf("%d\n", numbers[0][0]);





return 0;

}

I can't find why it's giving me a segmentation fault error

Here's the file it's pulling from...

Code:

1 4
11 3
4 2
0 0

The printf statement at the end is just to check if it's storing into the numbers array correctly.

Impatient little cuss, ain't he?

Who me?

Yeah... you started two identical threads less than 5 minutes apart....

Wild guess, your open is failing and ofp is null.
You should exit out if its null.

Dylan

Also you should move

int numbers[10][2];
int r, c, n;

Before the open.

Originally Posted by CommonTater

Yeah... you started two identical threads less than 5 minutes apart....

Yes...I does it not tater...so? Join he is not.

Code:

#include<stdio.h>
#include<stdlib.h>

int main()

{

FILE *ofp;
FILE *ifp;

int n, i, sum, input[100];
i = 0;
char numbers[][15] = {"Ace", "2", "3", "4", "5", "6", "7", "8", "9", "10", "Jack", "Queen", "King"};
char suite[][15] = {"Clubs", "Diamonds", "Hearts", "Spades"};

ofp = fopen("Result.dat", "w");

ifp = fopen("Cards.dat", "r");

if (ifp == NULL)
{
 printf("Unable to open Cards.dat");
}

fscanf(ifp, "%d", &n);

while (n != 0)
{
 input[i] = n - 1;
 ++i;
 fscanf(ifp, "%d", &n);
}

sum = i;

for (i = 0; i < sum; i = i + 2)
 {
  fprintf(ofp, "%s of %s\n", numbers[input[i]], suite[input[i - 1]]);
 }





return 0;

}

Not sure where it's getting this segmentation fault from...Any clues?

Code:

char numbers[13][] = {"Ace", "2", "3", "4", "5", "6", "7", "8", "9", "10", "Jack", "Queen", "King"};
char suite[4][] = {"Clubs", "Diamonds", "Hearts", "Spades"};

Do some reading... A Tutorial on Pointers and Arrays in C ... it may help.

Code:

for (i = 0; i < sum; i = i + 2)
 {
  fprintf(ofp, "%s of %s\n", numbers[input[i]], suite[input[i - 1]]);
 }

What happens in the marked section above when i = 0?

You are also opening files that you don't close...

Originally Posted by CommonTater

Code:

char numbers[13][] = {"Ace", "2", "3", "4", "5", "6", "7", "8", "9", "10", "Jack", "Queen", "King"};
char suite[4][] = {"Clubs", "Diamonds", "Hearts", "Spades"};

Do some reading... A Tutorial on Pointers and Arrays in C ... it may help.

Code:

for (i = 0; i < sum; i = i + 2)
 {
  fprintf(ofp, "%s of %s\n", numbers[input[i]], suite[input[i - 1]]);
 }

What happens in the marked section above when i = 0?

You are also opening files that you don't close...

Thanks Tater for the help! That tutorial is awesome!!!