Thread: changing array values using pointers

Originally Posted by dford425

I don't understand why i getting this error if i'm not trying to change the value of the pointer itself, just want it points to. Am i getting confused by how pointers work?

The problem is that you did not dereference the pointer, i.e., it should be:

Code:

*(text+i) = toupper((int)*(text+i));

Actually, it can be simplified to:

Code:

text[i] = toupper(text[i]);

Instead of manually performing the check to see if the current character is an alphabetic character, use isalpha. If you really must perform the check yourself, don't use magic numbers.

Also, your use of strncmp is wholly unnecessary. Rather, instead of leaving the loop condition empty, check for text[i] != '\0'.

This strikes me as overly complex...

First casting text as an int is wrong. Int's usually take up more space so you may be producing effects you don't want to have.

Second you could do this very easily with the traditional [] array indexing methods

Finally your loop conditions are screwey....

Code:

changeText(char* text, int count)
  {
  int limit = strlen(text);
  for(int i=0; i < limit ;i++)
   {
    //check to see if its a character
    if(isalpha(text[i]))
      {
      if((i % count) == 0)
         text[i] = toupper(text[i]);    
      else                                               
        text[i] = ' ';                           
       }
    }
 }

Another thing: you don't need the ptext variable when you call the function. You can simply write:

Code:

changeText(text, count);

Note that the text pointer parameter in changeText points to a const char. Therefore, you cannot change the string in the calling function through it, so the comment "make character a space" is illogical. Actually, the function name itself is illogical, unless you make the text parameter a pointer to non-const char instead (in which case the name merely becomes not very descriptive; something like nthLetterToUpper might be better).

CommonTater's suggestion of using strlen will work, except that it makes two passes through the string. Note also that there are several (deliberate?) mistakes in the example.

Well, if you want to provide a proper solution, I would have expected something like this:

Code:

void nthLetterToUpper(char *text, int n)
{
    int count = 0;
    int i;
    assert(text && "null pointer not allowed");
    assert(n > 0);
    for (i = 0; text[i] != '\0'; ++i)
    {
        if (isalpha(text[i]))
        {
            ++count;
            if (count % n == 0)
            {
                text[i] = toupper(text[i]);
            }
        }
        else
        {
            text[i] = ' ';
        }
    }
}

Originally Posted by dford425

The reason i am using pointers instead of typical array reference is because i want to practice with pointers.

Sure, but the way you are using pointer notation is pointless since the equivalent array notation is more readable. Either way, you are using a pointer since the parameter named text is a pointer. Here is my example with more sensible use of pointer notation:

Code:

void nthLetterToUpper(char *text, int n)
{
    int count = 0;
    assert(text && "null pointer not allowed");
    assert(n > 0);
    for (; *text != '\0'; ++text)
    {
        if (isalpha(*text))
        {
            ++count;
            if (count % n == 0)
            {
                *text = toupper(*text);
            }
        }
        else
        {
            *text = ' ';
        }
    }
}

Originally Posted by dford425

Also when i was writing it, the toalpha function did not even cross my mind so thats for that tip.

isalpha, not toalpha