Thread: Creating Directory structure

Hi I am using the following code to tokenise a string which contains a relative directory and then create the directory structure. Works fine for stuff like folder/folder1/folder2, but doesn't work for such directories as ../../folder/folder2. Any ideas how I can modify it to work for strings like that?

Code:

v
void createdirstruct(char *folder) {
  char	tokfolder[512];
  int	i;
  
  for (i = 0; i <= strlen(folder); i++) {
    if (folder[i] == '/' || folder[i] == '\0') {
      strncpy(tokfolder, folder, i);
      tokfolder[i] = '\0';
      if(mkdir(tokfolder, S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH) == -1) {
	printf("Restoring folder structure failed.\n");
	exit (13);
 
      }
    } 
  }
}

Thanks

And you'll have to be more explicit about what you mean by "works". So far as I can tell, all this code does is turn "folder/folder1/folder2" into "folder" and create a directory of that name. It doesn't continue on with the string. It doesn't deal with any of the other directories.

And trying to make the directory ".." is going to fail SO hard.

Forgot to copy the chdir bit. Erm well if I pass the function folder/folder1/folder2 It creates those folders just like that, one inside another. Just need a way to test if there is ../ and chdir instead of creating

Code:

void createdirstruct(char *folder) {
  char	tokfolder[512];
  int	i;
  
  for (i = 0; i <= strlen(folder); i++) {
    
    if (folder[i] == '/' || folder[i] == '\0') {
      strncpy(tokfolder, folder, i);
      tokfolder[i] = '\0';
      if(mkdir(tokfolder, S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH) == -1) {
	printf("Restoring folder structure failed.\n");
	exit (13);
      }
      if(chdir(tokfolder) == -1) {
	  printf("Directory change to %s failed\n",tokfolder);
	  exit (11);
      }
    } 
  }
}

Okay, so your tokenizing thing works, fine. Why not stat the name to see if it exists before blithely trying to create it? (I.e., this won't just fail on "..", but on "folder/" if that directory already exists.)

Yeah I think I will do that now. I've just got my order messed up. I used stat on the full string before this function is called, but obviously like you said I need to do it for each token