Thread: 'Exit' character in sequential file. I'm sure it is simple...

Could someone point out why my exit character 'x' is being written to my sequential file? I would really appreciate it. Thank You!

Code:

#include <stdio.h>
#include <stdlib.h>
#define N 100

FILE *fP;

main()
{
    char str[N];
    int i;

    fP = fopen("names.dat", "w");

    if ((fP = fopen("names.dat", "w")) == NULL)
        {
            printf("%s not opened", "names.dat");
            exit(EXIT_FAILURE);
        }


    printf("This program will write names and GPAs into a file named names\n");
    printf("Please enter an x to exit the program.\n");

    for(i=0; i<N; i++)
        {
            while (i < N && *str != 'x')
                {
                    printf("Please enter a student's name and their GPA separted by a space.\n");
                    gets(str);
                    fputs(str, fP);
                    fputs("\n", fP);
                    fflush(stdin);
                }
        }

    fclose(fP);

    return 0;
}

Also if you see any improvements I can make, please feel free to point it out. With that being said, please be kind.

Code:

                    gets(str);
                    fputs(str, fP);

That'll do it every time.

Originally Posted by quzah

Code:

                    gets(str);
                    fputs(str, fP);

That's why. You read a string, then immediately write it, then hit the loop check. There are so many errors in this program, I hardly know where to start. Well I suppose I'll just start at the top...

1. Avoid globals. Technically not "wrong", just not good.
2. main should be returning an int. Read the FAQ.
3. Why are you calling fopen twice?
4. You don't need to check i<N twice.
5. You don't dereference array names. I'm surprised this compiles.
6. gets. Read the FAQ.
7. fflush(stdin). Read the FAQ.


Quzah.

Sweet! Thanks!

Originally Posted by quzah

Code:

                    gets(str);
                    fputs(str, fP);

That's why. You read a string, then immediately write it, then hit the loop check. There are so many errors in this program, I hardly know where to start. Well I suppose I'll just start at the top...

1. Avoid globals. Technically not "wrong", just not good.
2. main should be returning an int. Read the FAQ.
3. Why are you calling fopen twice?
4. You don't need to check i<N twice.
5. You don't dereference array names. I'm surprised this compiles.
6. gets. Read the FAQ.
7. fflush(stdin). Read the FAQ.


Quzah.

Forgive me, but I am not understanding the "dereference of array names." Could you help me understand it? Thanks!

Originally Posted by quzah

This:

Code:

char str[N];  <--- array
...
            while (i < N && *str != 'x') <-- dereferencing

You only dereference actual pointers, not arrays.

Quzah.

Thanks for the info! I appreciate it.

Still having problems here. I have to use a do/while loop. I put the fputs outside the loop and still get an "x" character inside my file. Can anyone help me with this?

Code:

#include <stdio.h>
#include <stdlib.h>
#define N 100

int main()
{
    FILE *fP;
    char str[N], *p;
    p = str;
    int counter = 0;

    if ((fP = fopen("names.dat", "w")) == NULL)
    {
        printf("%s not opened", "names.dat");
        exit(EXIT_FAILURE);
    }

    printf("This program will write names and GPAs into a file named names\n");
    printf("Please enter an x to exit the program.\n");

        do
        {
            gets(str);
            fputs(str, fP);
            fputs("\n", fP);

        }while (*p != 'x');



        fclose(fP);

    return 0;
}

Also is the pointer used correctly for the array?

Code:

            gets(str);
            fputs(str, fP);

Do you see anything at all between these lines that would be able to prevent you from doing the second one (printing to the file) after the first one has happened? Once you read it in, you spit it directly out.

Also why bother with p? And for that matter what if the file contains "xenon"? Are you supposed to quit on that x as well, or just an x by itself?

Originally Posted by tabstop

Code:

            gets(str);
            fputs(str, fP);

Do you see anything at all between these lines that would be able to prevent you from doing the second one (printing to the file) after the first one has happened? Once you read it in, you spit it directly out.

Also why bother with p? And for that matter what if the file contains "xenon"? Are you supposed to quit on that x as well, or just an x by itself?

As I had said before, I have tried putting the fputs OUTSIDE of the do/while loop and still get an "x" character inside my file. I assume that the character "x" is inside single quotes in the "does not equall" condition is not the same as xenon inside single quotes. Is that not correct?

Originally Posted by csharp100

As I had said before, I have tried putting the fputs OUTSIDE of the do/while loop and still get an "x" character inside my file.

When you get outside of the loop, "x" is all you have so of course that's what gets printed. What you need is read / check / if-ok-then-print, not read / print / check / print.

Originally Posted by csharp100

I assume that the character "x" is inside single quotes in the "does not equall" condition is not the same as xenon inside single quotes. Is that not correct?

That is amazingly not correct. *p represents just the first character of the string, not the string-as-a-whole.

Originally Posted by tabstop

When you get outside of the loop, "x" is all you have so of course that's what gets printed. What you need is read / check / if-ok-then-print, not read / print / check / print.

That is amazingly not correct. *p represents just the first character of the string, not the string-as-a-whole.

Fair enough, than what do you suggest for an exit character?

Guys, I understand what you are saying but I am not fathoming it inside a do/while loop in which it must be done this way. If it was not for that directive, I would not be on here. It is the logic of the do/while I am getting lost in. From my instructor, "repeat reading strings until some prohibited value is entered (use do/while loop). I do not see how I can read a string, check that string then print it if it is correct when I am the one creating the file. It is not reading from another file. This program is only worth 7 points so it cannot be a bunch of lines of code. That is the way she operates.

Code:

while (1)
   {        
      gets(str);
      if (strcmp(str,"x") != 0)    
        { fputs(str, fP);
           fputs("\n", fP); }
      else
        break;
   }

Like they've been telling you to do...