Thread: Error in my code...not sure what i did wrong

Ok, so this is just a stupid little program i wrote for class...it will not compile here it is.

Code:

#include <stdio.h>
#include <stdlib.h>

int main( void )
{
    int gallons;
    int gallons1;
    int gallons2;
    double upb;
    int charge = 35;
    int latefee = 2;
    double total = 0;

    
    
    
    
    
    
    
    while ( gallons != -1 ) {
    
    printf( "THANK YOU FOR CHOOSING PLEASANT WATER AUTHORITY\n\n" );
    printf( "Enter the current quarters readings:\n" );
    printf( "                    " ); 
    scanf( "%d", &gallons );
    printf("Enter last quarters readings:\n" );
    printf( "                    " );
    scanf( "%d", &gallons1 );
    printf( "Enter last years readings, this quarter:\n" );
    printf( "                    " );
    scanf( "%d", &gallons2 );
    printf( "Enter any unpaid balance from last quarter:\n" );
    printf( "                    " );
    scanf( "%.2f", &upb );
    
    if ( upb = 0 && gallons <= gallons2 * .95 ) {
         total = gallons * (1.10 / 1000) + latefee + charge;
         printf( "Your total due this quarter is:\t %.2f\n\n", total );
         printf( "Congratulations, you have been environmentally green this quarter!\n\n" );
}
         
         
    if ( gallons > gallons2 * .95 && upb > 0 ) { 
             total = gallons * (2.20 / 1000) + charge + upb + latefee;
			 printf( "You have an unpaid balance of %.2f\n\n", upb );
             printf( "Your total due this quarter is:\t %.2f\n\n", total );
             printf( "You were not environmentally green this quarter.\n\n");
}


    if ( gallons <= gallons2 * .95 && upb > 0 ) {
             printf( "You have an unpaid balance of %.2f\n\n", upb );
			 printf( "Congratulations, you have been environmentally green this quarter!\n\n" );
             total = gallons * (1.10 / 1000) + latefee + upb + charge;
             printf( "Your total due this quarter is:\t %.2f\n\n", total );
}


    //here is the compilation error, the 'if' statement
         if ( gallons > gallons2 * .95 && upb = 0 ) {
             total = gallons * (2.20 / 1000) + charge + upb;
	printf( "Your total due this quarter is:\t %.2f\n\n", total );
	printf( "You were not environmentally green this quarter.\n\n" );
}

}
     system("PAUSE");
     return 0;
     
}

any help would be appreciated. thank you

Excuse me, i got it to compile and run, however...there is no output. it just instantly loops back up after the final input is put in and restarts.

What error messages is the compiler giving you?
Most times it will tell you exactly what's wrong...

So now, i am trying to figure out what is wrong with my loop. i will post the new code and it will produce strange results.

Code:

#include <stdio.h>
#include <stdlib.h>

int main( void )
{
    int gallons;
    int gallons1;
    int gallons2;
    double upb;
    int charge = 35;
    int latefee = 2;
    double total = 0;

    
    
    
    
    
    
    
    while ( gallons != -1 ) {
    
    printf( "THANK YOU FOR CHOOSING PLEASANT WATER AUTHORITY\n\n" );
    printf( "Enter the current quarters readings:\n" );
    printf( "                    " ); 
    scanf( "%d", &gallons );
    printf("Enter last quarters readings:\n" );
    printf( "                    " );
    scanf( "%d", &gallons1 );
    printf( "Enter last years readings, this quarter:\n" );
    printf( "                    " );
    scanf( "%d", &gallons2 );
    printf( "Enter any unpaid balance from last quarter:\n" );
    printf( "                    " );
    scanf( "%.2f", &upb );
    
    if ( upb = 0 && gallons <= gallons2 * .95 ) {
         total = gallons * (1.10 / 1000) + latefee + charge;
         printf( "Your total due this quarter is:\t %.2f\n\n", total );
         printf( "Congratulations, you have been environmentally green this quarter!\n\n" );
}
         
         
    if ( gallons > gallons2 * .95 && upb > 0 ) { 
             total = gallons * (2.20 / 1000) + charge + upb + latefee;
			 printf( "You have an unpaid balance of %.2f\n\n", upb );
             printf( "Your total due this quarter is:\t %.2f\n\n", total );
             printf( "You were not environmentally green this quarter.\n\n");
}


    if ( gallons <= gallons2 * .95 && upb > 0 ) {
             printf( "You have an unpaid balance of %.2f\n\n", upb );
			 printf( "Congratulations, you have been environmentally green this quarter!\n\n" );
             total = gallons * (1.10 / 1000) + latefee + upb + charge;
             printf( "Your total due this quarter is:\t %.2f\n\n", total );
}


             if ( upb = 0 &&  gallons > gallons2 * .95  ) {
             total = gallons * (2.20 / 1000) + charge + upb;
	printf( "Your total due this quarter is:\t %.2f\n\n", total );
	printf( "You were not environmentally green this quarter.\n\n" );
}

}
     system("PAUSE");
     return 0;
     
}

here it is

I do hope you don't think we're sitting here compiling your code...

Describe what you expect and what it's doing....
What should it produce?
What does it produce?

Well, it produces almost everything i need. Except for after the final input of unpaid balance it doesnt display any of the 'if' statements and it just loops back up to "THANK YOU FOR CHOOSING PLEASANT WATER AUTHORITY"

Bayint, I've reviewed it now, and I see not problems. I'm quite sure there is something wrong with that statement otherwise you would not have posted that line.

The logic here seems to me that -- if the unpaid balance is 0, and this quarters gallons is less than 95% of last years, then display the appropriate results.

Well, that is suppose to be the logic, however, is that not exactly what I have written?

Well, my teacher said it doesnt matter, she told us to use -1 to exit, and because she has not taught us better methods because we have not gotten that far yet in class, that there will be no need to add the line directing the user to enter the sentinel value. and yes, I suppose that would be a good idea O.o thank you. Im still trying to grasp some of the syntax and logic in programming, i appreciate all critiques.

Yes, i have changed to == in both if statements. Currently I am working on formatting the ouput. I want the cursor to be right aligned when the user enters the initial values. working on that. also, one other thing i am working on is that when the user types in the upb ( unpaid balance), the out put is always 0 regardless of what value was actually typed in. finally, when the loop comes back after the program runs, and it restarts and asks the user to enter gallons, it skips that step and is automatically set on last quarters gallons to enter. those are 3 problems im currently working on, any help is appreciated.

Code:

    scanf( "%.2f", &upb );

Just use scanf("%f",&upb);

alright, i took away the ".2" did not seem to have any effect, however I am curious as to why the .2 should have been taken away, Does the compiler automatically recognize a double having two decimal places? I am simply trying to learn, sorry if I am so full of skepticism and questions.