Returning A String Array

Code:

---

.........
char **words = readFile(in);
printf("%s\n", words[0]);
.........

char **readFile(FILE *in)
{
        char **warr;
        ............
        return warr;
}

---

Trying to return the array and be able to print out what i read into the array. Read file works fine and i can print out the words in the array but having problems passing it back into another function after the call.

Quote:

---

....but having problems...

---

I hate when that happens.

Could someone help me out please?

You are returning the address of a locally declared variable. If you want to get information from warr out of the function, you need to pass it in as a parameter to the function after declaring it elsewhere.

I think.

Code:

---

#include <stdio.h>
#include <stdlib.h>

FILE *in;
char **readFile();

void main()
{
        in = fopen("sentences.in", "rt");
        char **words;
        words = readFile(in);
        printf("%s\n", words[0]);
}

char **readFile(FILE *in)
{
        char *word, **warr;
        word = (char*)malloc(25 * sizeof(char));
        for(int i = 0; i < 28; ++i)
        {
                fscanf(in, "%s", word);
                if(i >= 28)
                {
                        printf("Only %d words can be used in your input file.", 20);
                }
                warr[i] = calloc(strlen(word) + 1, sizeof(char));
                strcpy(warr[i], word);
        }
        printf("%s\n", words[0]);
        return warr;
}

---

Prints word from input file in readFile but doesn't do it in main after the return. It's not being pass correctly and I'm not sure how to do it :/

Not too bad, but you first need to allocate warr, before using warr[i]

For your specific program at the moment, this would be

Code:

---

warr = malloc( 28 * sizeof(*warr) );

---

> if(i >= 28
This is never true inside a for loop with the opposite condition controlling it.

Quote:

---

Originally Posted by Salem

Not too bad, but you first need to allocate warr, before using warr[i]

For your specific program at the moment, this would be

Code:

---

warr = malloc( 28 * sizeof(*warr) );

---

> if(i >= 28
This is never true inside a for loop with the opposite condition controlling it.

---

I did that I just put the code that refers to word since that is what I'm having trouble passing :/

Returning Arrays

> I did that I just put the code that refers to word since that is what I'm having trouble passing :/
So in other words, this thread is a waste of time, because your actual code is nothing like your posted code.

Post your ACTUAL code if you want people to tell you what is actually wrong.
Otherwise, we just waste time pointing out what is wrong with your attempt to be brief.

Salem, why aren't you complaining about void main? :(

This thread started out sloppy, and is still sloppy. Sigh....