Thread: initializer element is not constant error - help

I am working on a program that is to call many different functions from a choice menu. I been able to get many of the functions done and call from the menu except this one function. When I compile it, it gives me a initializer element is not constant. This function was actually a program we had done earlier but now using it in a choice menu program. It works and compiles just fine on it's own but when I insert in as a function it gives me this error. The entire programs is long so I am only posting part of the function I am having problems with since this is a school assignment. I get the error right at the random number generator.

Code:

int multgame();  //function name

srand(time(0));
  
int i;
int num1 = rand()%50;
int num2 = rand()%50;
int answer, guess, problems;


//Answer to the random numbers generated
answer = num1*num2; 

//Get user input for how many problems they want to do   
 printf("How many problems do you want?\n");
 scanf("%d", &problems);

There is no array in this code. Post the line where the error is occurring.

In the future, please indicate the line that is giving you the error. "Right at the random number generator" is not as clear as simply pointing out the offending line.

I can only guess at your problem because you have not posted a complete program. My guess is that you have

Code:

int num1 = rand()%50;

outside of any function. If this is the case, then that's the source of your error. Global variables cannot be initialized by a function call. They have to be initialized with a value that can be computed at compile time.

You should avoid global variables in the first place, if it's feasible to do so; but at any rate you'll need to call rand() inside of a function.

If this was not the issue, you'll have to be more clear.

You get the same problem everytime because you pick your random number outside the loop. You need to move the two rand() calls into your loop so that you get new numbers each time. That should also clear up the intializer not constant error you're getting.

Whoops, having never seen this error I was figuring this was an attempt to initialize an array with a non-constant size. My bad!

ohhh ok thanks commontater, that fixed it.

No worries....