Bitcount code

This is a discussion on Bitcount code within the C Programming forums, part of the General Programming Boards category; Hello, I am trting to write a program that accepts numbers and count the number of bits in the given ...

  1. #1
    Registered User
    Join Date
    Oct 2010
    Posts
    17

    Bitcount code

    Hello,

    I am trting to write a program that accepts numbers and count the number of bits in the given array of numbers. However my output is incorrect, I get the following

    Enter nums:
    10101010
    The total count is 7


    Code:
    //Program that accepts a number and counts the bits.
    
    #include <stdio.h>
    
    int bitcnt(unsigned x);
    
    int main (int argc, char *argv[]) {
        unsigned x;
    
        printf("Enter nums:\n");
        scanf("%d", &x);
    //    bitcnt(x);
    
         printf("The total count is %d\n", bitcnt(x));
    
         return 0;
    }
    
    
    int bitcnt(unsigned x) {
        int b;
    
      for(b=0; b<x; x>>=1) {
        if(x&01) {
          b++;
         }
      }
    //   printf("The total count is %d\n", b);
        return b;
    }
    All help is greatly appreciated.

  2. #2
    Registered User
    Join Date
    Aug 2010
    Posts
    231
    Code:
    int bitcnt(unsigned x) {
        int b;
    
      for(b=0; x; x>>=1) {
        if(x&1) {
          b++;
         }
      }
    //   printf("The total count is %d\n", b);
        return b;
    }

  3. #3
    Registered User
    Join Date
    Oct 2010
    Posts
    17
    Ah ha ...

    That makes sense now. Thanks alot for that.

    Also is this the correct output?

    Enter nums:
    1001
    The total count is 7

    Thank You

  4. #4
    Registered User
    Join Date
    Sep 2006
    Posts
    8,868
    Well, no - clearly there are 8 bits in a byte.

    Counting like a C programmer, are you?

  5. #5
    Registered User
    Join Date
    Oct 2010
    Posts
    17
    Well....Thanks for that

    I dont quite understand why it is giving me that output and what i should do to modify it.

    Thank You

    Also i am new to programming, so my knowledge is a bit limited about C language.

  6. #6
    Banned
    Join Date
    Aug 2010
    Location
    Ontario Canada
    Posts
    9,547
    Code:
        printf("Enter nums:\n");
        bitcnt += scanf("%d", &x);
    
    // OR
    
    
        printf("Enter nums:\n");
        scanf("%d", &x);
        ++bitcnt;

  7. #7
    Registered User
    Join Date
    Mar 2009
    Posts
    344
    1001 is 1111101001 in binary, so it has 7 1-bits in it and the answer is correct. Now you have to figure out if you've asked the correct question.

    If you want to treat your input as a binary value, look into reading it as a string and then counting the number of 1s in that string.

    If you want figure out how many bits in total, look at the sizeof() operator combined with the CHAR_BIT value defined in limits.h.

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. Extended ASCII Characters in an RTF Control
    By JustMax in forum C Programming
    Replies: 18
    Last Post: 04-03-2009, 09:20 PM
  2. Enforcing Machine Code Restrictions?
    By SMurf in forum Tech Board
    Replies: 21
    Last Post: 03-30-2009, 08:34 AM
  3. Obfuscated Code Contest
    By Stack Overflow in forum Contests Board
    Replies: 51
    Last Post: 01-21-2005, 04:17 PM
  4. Interface Question
    By smog890 in forum C Programming
    Replies: 11
    Last Post: 06-03-2002, 06:06 PM
  5. Replies: 0
    Last Post: 02-21-2002, 06:05 PM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21