Thread: quick bubble sort question

hi all

can someone please explain whey this buble sort doesnt work. Many thanks

Code:

#include <stdio.h>

int main(int argc, char *argv[]){
    int a,b;
    int array[4];
    int i;
    int swapped;
    printf("Enter 5 integers\n");
    for (i=0;i<4; i++){
        scanf("%d", &a);
        array[i]=a;
        printf("%d", array[i]);
    }
    swapped=1;
    while (swapped){
        swapped=0;
        for (i=0;(i<4)&&(swapped=0); i++){
        if (array[i]>array[i+1]){
        b=array[i];
        array[i]=array[i+1];
        array[i+1]=b;
        swapped=1;
        }

        printf("%d\n", array[i]);
    }


    return 0;
}}

change (swapped=0) to (swapped==0)

Probably

Code:

 while (swapped){
        swapped=0;
//        for (i=0;(i<4)&&(swapped=0); i++){ wrong
        for (i=0;(i<4)&&(swapped==0); i++){
        if (array[i]>array[i+1]){
        b=array[i];
        array[i]=array[i+1];
        array[i+1]=b;
        swapped=1;
        }

hi all thx for the quick replies

i changed the code but it does not work
i also want to know how t fix the same number issue if let say u put 15 12 15 12 15

Code:

#include <stdio.h>

int main(int argc, char *argv[]){
    int a,b;
    int array[5];
    int i;
    int swapped;
    printf("Enter 5 integers\n");
    for (i=0;i<5; i++){
        scanf("%d", &a);
        array[i]=a;
      //  printf("%d", array[i]);
    }


    swapped=1;
    while (swapped){
        swapped=0;
        for (i=0;(i<4)&&(swapped==0); i++){
        if (array[i]>array[i+1]){
        b=array[i];
        array[i]=array[i+1];
        array[i+1]=b;
        swapped=1;
        }


        printf("%d\n", array[i]);
    }





    return 0;

}}

This must work, check your test-output AFTER the while-loop like:

Code:

    for (i=0; i<5; i++)
        printf("\n%d", array[i]);

can someone please explain whey this buble sort doesnt work. Many thanks

Because there's no such thing as a buble sort.

Hey Geoff, Welcome to the forum!