Why does my calculator crash?

I wrote a simple calulator in C, trying to teach myself the language because I'm accustomed to C++, but the program crashes once user inputs the second number for calculation. I'm wondering if there's something wrong with my code (though I can't seem to spot anything) or that Windows 7 doesn't get along with C. Can anyone tell me what's the issue is here?

The code is as follows:

Code:

---

#include <stdio.h>

int main(void){

        int geti[3];

        printf("Write something: ");
                scanf("%d", geti[0]);
        printf("write something else: ");
                scanf("%d", geti[1]);

        geti[2] = geti[0] + geti[1];

        printf("Your sum is %d", geti[2]);
        return 0;
        }

---

Do you get anyerror/warning messages when you compile? (you should).

Jim

you need to pass address like so

Code:

---


#include <stdio.h>

int main(void){

        int geti[3];

        printf("Write something: ");
        scanf("%d", geti[0]);
        printf("write something else: ");
                scanf("%d", geti[1]);

        geti[2] = geti[0] + geti[1];

        printf("Your sum is %d", geti[2]);
       
       
        return 0;
}

---

You forgot to pass the address, like so:

>>scanf("%d", &geti[0]);
>>scanf("%d", &geti[1]);

Out of curiosity, for someone knowing C++, why would you learn C now?

Quote:

---

Originally Posted by ahernan17

I wrote a simple calulator in C, trying to teach myself the language because I'm accustomed to C++, but the program crashes once user inputs the second number for calculation. I'm wondering if there's something wrong with my code (though I can't seem to spot anything) or that Windows 7 doesn't get along with C. Can anyone tell me what's the issue is here?

The code is as follows:

Code:

---

#include <stdio.h>

int main(void){

        int geti[3];

        printf("Write something: ");
                scanf("%d", geti[0]);
        printf("write something else: ");
                scanf("%d", geti[1]);

        geti[2] = geti[0] + geti[1];

        printf("Your sum is %d", geti[2]);
        return 0;
        }

---

---

Shold be scanf("%d", &geti[0]); etc.

Well now that was a duh issue, the passing worked like a charm. Thanks for the help.

And for the guy asking about why I would want to learn C, I just like the simplicity of the language and it never hurts to expand your tongue. Though I'm sure some would argue otherwise.

Honestly, C is anything but simple.

Like I said, some people would argue that. Though I am just a deviant.

It's a fact. Whether or not you find it simple to understand, use and learn is another matter.

But worth it from what I've seen.

Interesting observation. How do you figure? Curiousness? Power? Flexibility?

All of those, but mostly curiousness, considering things such as Unix, Linux, lots of GNU programs, SDL and OpenGL are built from C, I'd gather it will get any job done, when done right.

Unix/Linux is in C because C++ didn't exist / wasn't mature at the time.
SDL / OpenGL is in C mainly, I believe, due to backwards compatibility for C (for some bizarre reason).
A lot of GNU programs being C is mostly a mistake.

I will say this, though. C is a very dangerous language, and it's a primitive language.
It is not suited very well for today's demands for applications.
Thus, using C for any modern applications for PC is a mistake, if for anything else than learning, or just as a hobby. But even as a hobby, it's really stretching its limits. C is a big secure hole that needs to be used properly in order not to cause significant security risks.

Consider that C++ will also get any job done, in shorter time too usually, no less. It also creates more flexible design and less security holes.
Games are very complicated pieces of software, and 99% of them are written in C++, and for good reason. C is out of the question for that 99%. Ponder on that.

Elysia: please stop preaching against C in the C programming forum. I can understand if you are suggesting that another language is better than C for a given problem at hand, but here the problem is an exercise to learn C.

No, no trying to say don't learn C. Just trying to make the OP understand C and its limits.
Trying to iron out misconceptions such as C, and only C, can do all these tasks. If you're going to learn C, you should understand what it is and what it isn't.
So long as you're aware of that, it's fine.
Right?

I mean, a lot of people learning C are under the impression that C is the language, capable of everything. There must a reason why everything is written in C, right!?!
It just turns out that it isn't true. We have other great languages, as well.
So don't learn C because it is the language. You're just shooting yourself in the foot.
Learn it because of curiosity, as a hobby, or where no other languages are available.

Every language has its limits.
No one here is saying to use ONLY Any single language either.
And whether it's a mistake or not to use C to write such program/software is just your opinion.

@laserlight, i think you'll need to close this thread soon...;)

Even so that is not the point. The point is that this is a C programming forum and discussing C is appropriate. If that is all it takes to get you to compare C to something else, you will always be unhappy with people's choices.

Quote:

---

Originally Posted by Bayint Naung

Every language has its limits.
No one here is saying to use ONLY Any single language either.
And whether it's a mistake or not to use C to write such program/software is just your opinion.

@laserlight, i think you'll need to close this thread soon...;)

---

No, it's not. C is a huge security risk. C increases development time (if you compare to someone equally skilled in another language, say Java/C#). These are facts.
The fact that C is so incredible inferior to any other languages in terms of features and tools it gives you is a reason I don't want to see software for PC in C, but that's an opinion and subjective.
More importantly, consider the security risks. C wasn't designed for that. Therefore, I strongly recommend against using C for PC software.
Security is not something to be underestimated. Know this. Then employ C appropriately. I will not say where you are allowed to use it or not. That's completely up to you. I am merely saying that you should know what you are doing.

The end.
So let's put a stop to this debate before it really gets locked.
Signing out.

>>I mean, a lot of people learning C are under the impression that C is the language, capable of everything. There must a reason why everything is written in C, right!?!
Yes, that is probably true for some people, just as you are convinced that C++ is being used 99% of the time for everything desktop or game-related. Just because you start to learn something under false pretenses doesn't mean that you should stop learning it. You might disagree, but that isn't the point. If discussing C is all it takes to get you to compare it to something else, you will continue to do that to the point where the mods have to tell you to stop. You apparently won't listen to anyone else.

I'm enjoying this argument, but we should move to a more appropriate thread:

http://cboard.cprogramming.com/c-pro...tml#post977963

Quote:

---

Originally Posted by Elysia

I am merely saying that you should know what you are doing.

---

Shall I throw some of these facts at you in the C++ forum whenever you say something positive about C++? After all, it is a fact that C++ code can pose a huge security risk and that C++ increases development time (if you compare to someone equally skilled in another language, say Java/C#).

Seriously, stop preaching. *thread closed*