problem passing to array

I am having some serious issues trying to pass the elements into the array at the end of the code segment. but i dont understand why, it prints them just fine but for some reason instead of printing them i want them into an array, but i just get a seg fault when i try to assign them to the array. it seems like a simple problem that i am just not seeing :/

so this is what i have so far...

Code:

#include <stdlib.h>
#include <stdio.h>

int main ( int argc, char *argv[] )
{
    if ( argc != 2 )
    {
        printf( "usage: %s filename", argv[0] );
    }
    else 
    {
        FILE *file = fopen( argv[1], "r" );
        
        if ( file == 0 )
        {
            printf( "Could not open file\n" );
        }
        else 
        {
            int x;
            int i = 0;
            
            arr[5]   //right now im just assuming the size of the array is 5 cuz thats my test file size
              
            while  ( ( x = fgetc( file ) ) != EOF )
            {
               // printf( "%c", x );
                  arr[i] = x;
                  i++;
            }
         
        }
        fclose( file );
    }
}

if it helps the test file looks like this:
8.3945
4.3495
2.3598
5.0382
7.9384

and what is the type of arr?

The file contains 5 floating point numbers plus assorted new-lines? Then reading a character at a time will certainly overflow the array of 5 elements.

sorry, the array is of type int. How do I get around it overflowing then?, should I use malloc, iv just been playing around with this for hours, so I'm really lost and confused. :/

Originally Posted by helg

sorry, the array is of type int. How do I get around it overflowing then?, should I use malloc, iv just been playing around with this for hours, so I'm really lost and confused. :/

We're at the super market, to get a dozen watermelons. You ask the produce guy for a container to put the watermelons in, and he hands you an egg carton.

That's what you're doing with arr[]. If you want arr[] to hold floats, then make it a float data type array, NOT an int array. Drop fgetc() also, since it doesn't handle floats.

You don't need malloc(). You need to declare arr[] as an array of type float. You need to match the data type going into the array, with the data type OF the array.

i figured it out, not only was i using the wrong type for the array, i was reading it character by character because i was using fgetc. so i switched the array type to float and used fscanf and it works now!