bitcount.c

[kezkez]

I am trying to get this to read a files integers and print the number of 1 bits in each integer. The file I am redirecting as input to test with has 100 in it. But the output I'm getting is:

Number of bits set to 1 in 49 = 3


Number of bits set to 1 in 48 = 2


Number of bits set to 1 in 48 = 2


Number of bits set to 1 in 10 = 2

I'd like to be getting Number of bits set to 1 in 100 = 3

Not sure if the while loop is correctly coded or what, can you help out?

#include <stdio.h>
#define EOF (-1)
unsigned char bitcount(unsigned char);

main()
{
  int i;
  unsigned char count, i8;

 while ((i = getchar() ) != EOF) 
 {
   if ((i < 0) || (i > 255)) { 
     printf("Number out of range = %d\n", i);
     exit(1);
   }
   else
   {
   i8 = (unsigned char) i;
   count = bitcount(i8);   

   printf("\n\nNumber of bits set to 1 in %d = %d\n",i,count);
   }//end else
 } //end while
} //end main


/* bitcount: count 1 bits in x */
unsigned char bitcount(unsigned char x)
{
  unsigned char count;

  for (count = 0; x != 0; x >>=1)
   if (x & 01)
    count++;
  return count;
}

[Memloop]

You're reading the numbers as ASCII characters, not the actual numeric values. Entering 100 will actually be interpreted as '1', '0', '0', '\n'. I suggest you use fgets instead of getchar and convert the input string to a number using strtol.

[hk_mp5kpdw]

That's because you're using getchar to read input. It reads the '1' char and converts that to its ASCII value of 49, then it reads the two '0' characters and converts those both to 48, the value 10 probably happens because there is a newline character in the redirected file. Bottom-line is you should use some other method of getting input. Perhaps scanf with %d format specifier to read an actual integer instead of characters.

[edit]Oops, too late![/edit]

[kezkez]

Ah, understand what it was doing with the ASCII now.

This is what I previously had...

#include <stdio.h>

unsigned char bitcount(unsigned char); 

main()
{  
   unsigned char i8,count;
   int i;

  printf("Enter number (0 - 255 decimal)\n");  
  scanf("%d",&i);
   

     if (( i < 0 ) || (i > 255))
     {
      printf("Error:Number out of range = %d\n", i);
      exit(1);
     }
  
   i8 = (unsigned char) i;
   
   count = bitcount(i8);
   
   printf("\n\nNumber of bits set to 1 in %d = %d\n",i,count);
   
}

unsigned char bitcount(unsigned char x)

{  
unsigned char count;

   for (count = 0; x!=0; x>>=1)
     if ( x & 01 )
       count++;
       
  return count;
}

but the instructor wants us to "not prompt the user for the amount of input, but just process the data until the end of input. If you create a file called mydata.txt with the list of numbers to test, you should be able to invoke your code as:
./bitcount.exe < mydata.txt

[MK27]

You could use strtol() to convert the string number to an int.

[itCbitC]

but the instructor wants us to "not prompt the user for the amount of input, but just process the data until the end of input. If you create a file called mydata.txt with the list of numbers to test, you should be able to invoke your code as:
./bitcount.exe < mydata.txt

Then don't prompt the user for input and enclose the scanf() and other statements, excluding the last printf(), inside a loop.

[kezkez]

This is what I've come up with so far. I got it to work for the first string for example where the file mydata.txt contains: 123 . But if the mydata file contains a second string I cannot get it to work for example: 123 456 it will read 123 but not 456. What am I missing?

#include<stdio.h>
#include<stdlib.h>

int bitcount(int);

main()
{
 char i;

 int count,i8;

  while( i != EOF)
  {
    scanf("%d",&i);
       
    i8 = (int) i; 

    count = bitcount(i8);
 
   printf("\n\nNumber of bits set to 1 in %d = %d\n",i,count);
return 0;
  }//end while
}//end main

/* bitcount */
int bitcount(int x)
{
  int count;
  for (count = 0; x !=0; x >>= 1)
   if (x & 01)
   count++;
  return count;
}

output:
Number of bits set to 1 in 123 = 6

[quzah]

scanf("%d",&i);
[/color] i;

Why are you using %d to read into a char? Why isn't i an int?


Quzah.

[kezkez]

ok, i did that, but any suggestions on how to get the loop to work for more that one string?

#include<stdio.h>
#include<stdlib.h>

int bitcount(int);
main() {
 int count, i; 
  while( i != EOF)
  {
    scanf("%d",&i); 
    count = bitcount(i);
   printf("\n\nNumber of bits set to 1 in %d = %d\n",i,count);
return 0;
  }//end while
}//end main

/* bitcount */
int bitcount(int x){
  int count;
  for (count = 0; x !=0; x >>= 1)
   if (x & 01)
   count++;
  return count;
}