Thread: C code crashing question.

goal of this code is to type numbers and arrange them by order.
if i put number 2 it works fine but more than 2, dos just crashes.
I used bcc32 compiler.

Code:

#include <stdlib.h>
#include <stdio.h>
float order(int i, float * item);

void main ()
{
  float item[200];
  int i=0,j,p;
  
  do 
  {
	printf("item #%d: ",i+1); p = scanf("%f",&item[i]);
	i++;
  } while ( p != EOF && i<200);
  order (i,&item);
  
}
float order (int i, float * item)
{
  float * order;
  int t,k;
	order= malloc(i*sizeof(float));
 for (t= 0; t<i; t++)
	order[t]=0;
	printf("%d",i);
	printf("%d",sizeof(*order));
 system("pause");
 for (k = 0; k<i; k++)
	 if ( order[0]<= item[k] )
	order[0]=item[k];
	printf("%f",order[0]);
  system("pause");
 for ( t=1; t<i; t++)
 for (k = 0; k<i; k++)
 if ( order[t]<= item[k] && order[t-1] > item[k])
	order[t]=item[k];
 return 0;
 }

If you need to put things in order, implement a sorting algorithm, like these.

thanks for reply but still crashing even after i changed emmmmmmmmmmmmm (((

What sorting algorithm are you using? Why do you need to allocate memory??

When you get a crash, your first order of business should be to run your program through a debugger. That should tell you where the crash happened (and perhaps why, especially with Valgrind). Even if your debugger can't tell you why the crash happened, it can at least give you a good starting point.

i don't know, it is a homework from some beginning C program class so I could make up any algorithm as long as i reach the goal.